Stream: git-wasmtime

Topic: wasmtime / Issue #2619 bench-api: configure the bench API...


view this post on Zulip Wasmtime GitHub notifications bot (Jan 28 2021 at 19:42):

abrown opened Issue #2619:

After discussing https://github.com/bytecodealliance/wasmtime/pull/2612, @fitzgen and I agreed that the best way to configure the bench-api shared library for running benchmarks is with a configuration struct. This has advantages such as:

One additional thought is to version the configuration struct in some way (first field is a usize?) to verify that both sightglass and the bench-api shared library are operating on the same understanding of how to configure the benchmark.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 28 2021 at 19:44):

fitzgen commented on Issue #2619:

related: https://github.com/bytecodealliance/sightglass/issues/78

view this post on Zulip Wasmtime GitHub notifications bot (Jan 28 2021 at 19:45):

abrown commented on Issue #2619:

Another way of doing this would be to use environment variables to communicate from sightglass to the bench-api shared library, but this seems more prone to error.


Last updated: Dec 23 2024 at 13:07 UTC