Wasmtime GitHub notifications bot (Jan 14 2021 at 02:51): Wasmtime GitHub notifications bot (Jan 14 2021 at 02:51):cfallin commented on Issue #2581:
So this was it then? I'm really happy we were able to finally pin this down!
Could you add a comment describing the reason for the initial zeroing -- that NaN != NaN so
x == xdoesn't always generate all-1s?
Wasmtime GitHub notifications bot (Jan 14 2021 at 02:56):jlb6740 commented on Issue #2581:
So this was it then? I'm really happy we were able to finally pin this down!
Could you add a comment describing the reason for the initial zeroing -- that NaN != NaN so
x == xdoesn't always generate all-1s?@cfallin .. Yes, looking like that was it. I haven't done a lot of testing so we need to monitor. I will put a comment.
Wasmtime GitHub notifications bot (Jan 14 2021 at 02:58):cfallin commented on Issue #2581:
This bug has made me realize that we should be running tests under valgrind on CI -- it would've deterministically found this issue and made our lives a little easier! I'll create an issue for that.
Wasmtime GitHub notifications bot (Jan 14 2021 at 03:14):jlb6740 commented on Issue #2581:
This bug has made me realize that we should be running tests under valgrind on CI -- it would've deterministically found this issue and made our lives a little easier! I'll create an issue for that.
Yes, I was thinking the same thing. Either that and/or this memory sanitizer. Clean up the current issues and make sure it runs to completion.
Wasmtime GitHub notifications bot (Jan 14 2021 at 03:15):jlb6740 edited a comment on Issue #2581:
This bug has made me realize that we should be running tests under valgrind on CI -- it would've deterministically found this issue and made our lives a little easier! I'll create an issue for that.
Yes, I was thinking the same thing. Either that and/or memory sanitizer. Clean up the current issues and make sure it runs to completion.
Last updated: Dec 23 2024 at 12:05 UTC