Ekleog commented on Issue #2569:
Side-note:
preopened_dir
andpreopened_virt
could both be refactored to lower topreopened_handle
if making it take a function instead of directly a handle. I'm not yet sure whether that's something you'd want so restrained myself for now but it would be possible too, though I'm not really sure whatPendingPreopen
actually brings in practice compared to just opening ahead-of-time (and thus seeing potential errors happen as soon as possible)
pchickey commented on Issue #2569:
Hi. Sorry I missed your message on the bytecode alliance discord.
Your use case is important to me. I'm nearing completion of a complete rewrite of wasi-common that, among other things, redesigns the traits so that files and directories have distinct sets of methods. https://github.com/bytecodealliance/wasmtime/pull/2487 I expect this PR will land within a week or so. (When it is ready to land, i'll rename the wasi-c2 crate back to wasi-common, thats just a name under development.)
The new design of the ctx builder should support your use case possible - https://github.com/bytecodealliance/wasmtime/blob/pch/wasi_common_cap_std/crates/wasi-c2/src/ctx.rs#L104
Is it OK to close this PR and you can re-target your work at the rewritten wasi-common?
Ekleog commented on Issue #2569:
That sounds really reasonable, thank you! Is there a branch somewhere where wasmtime depends on this version of wasi-common so I could take a git-dependency and start developing against that version?
Ekleog edited a comment on Issue #2569:
That sounds really reasonable, thank you! Is there a branch somewhere where wasmtime-wasi depends on this version of wasi-common so I could take a git-dependency and start developing against that version?
Ekleog edited a comment on Issue #2569:
That sounds awesome, thank you! Is there a branch somewhere where wasmtime-wasi depends on this version of wasi-common so I could take a git-dependency and start developing against that version?
pchickey commented on Issue #2569:
If you're on that branch and depend on
wasi-c2-wasmtime
it should work in the place ofwasmtime-wasi
Ekleog commented on Issue #2569:
Great, I'll try doing that. Thank you!
Last updated: Dec 23 2024 at 12:05 UTC