wasmtime / Issue #2569 wasi-common: add preopened_handle,... · git-wasmtime

Stream: git-wasmtime

Topic: wasmtime / Issue #2569 wasi-common: add preopened_handle,...

Wasmtime GitHub notifications bot (Jan 12 2021 at 00:00):

Side-note: preopened_dir and preopened_virt could both be refactored to lower to preopened_handle if making it take a function instead of directly a handle. I'm not yet sure whether that's something you'd want so restrained myself for now but it would be possible too, though I'm not really sure what PendingPreopen actually brings in practice compared to just opening ahead-of-time (and thus seeing potential errors happen as soon as possible)

Wasmtime GitHub notifications bot (Jan 12 2021 at 00:08):

pchickey commented on Issue #2569:

Hi. Sorry I missed your message on the bytecode alliance discord.

Your use case is important to me. I'm nearing completion of a complete rewrite of wasi-common that, among other things, redesigns the traits so that files and directories have distinct sets of methods. https://github.com/bytecodealliance/wasmtime/pull/2487 I expect this PR will land within a week or so. (When it is ready to land, i'll rename the wasi-c2 crate back to wasi-common, thats just a name under development.)

The new design of the ctx builder should support your use case possible - https://github.com/bytecodealliance/wasmtime/blob/pch/wasi_common_cap_std/crates/wasi-c2/src/ctx.rs#L104

Is it OK to close this PR and you can re-target your work at the rewritten wasi-common?

Wasmtime GitHub notifications bot (Jan 12 2021 at 00:09):

Ekleog commented on Issue #2569:

That sounds really reasonable, thank you! Is there a branch somewhere where wasmtime depends on this version of wasi-common so I could take a git-dependency and start developing against that version?

Wasmtime GitHub notifications bot (Jan 12 2021 at 00:12):

Ekleog edited a comment on Issue #2569:

That sounds really reasonable, thank you! Is there a branch somewhere where wasmtime-wasi depends on this version of wasi-common so I could take a git-dependency and start developing against that version?

Wasmtime GitHub notifications bot (Jan 12 2021 at 00:16):

Ekleog edited a comment on Issue #2569:

That sounds awesome, thank you! Is there a branch somewhere where wasmtime-wasi depends on this version of wasi-common so I could take a git-dependency and start developing against that version?

Wasmtime GitHub notifications bot (Jan 12 2021 at 00:22):

pchickey commented on Issue #2569:

If you're on that branch and depend on wasi-c2-wasmtime it should work in the place of wasmtime-wasi

Wasmtime GitHub notifications bot (Jan 12 2021 at 13:12):

Ekleog commented on Issue #2569:

Great, I'll try doing that. Thank you!

Last updated: Nov 22 2024 at 16:03 UTC