Stream: git-wasmtime

Topic: wasmtime / Issue #2528 Add safe Memory::read and Memory::...

Wasmtime GitHub notifications bot (Dec 20 2020 at 02:41):

github-actions[bot] commented on Issue #2528:

Subscribe to Label Action

cc @peterhuene

<details>
This issue or pull request has been labeled: "wasmtime:api"

Thus the following users have been cc'd because of the following labels:

• peterhuene: wasmtime:api

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Jan 26 2021 at 04:03):

theduke commented on Issue #2528:

I implemented your suggestion, the code definitely is much more elegant this way.

I also added a _private field to the error for extensibility and moved the test to tests/all/externals.rs since most tests seem to live there.

Wasmtime GitHub notifications bot (Jan 26 2021 at 04:04):

theduke edited a comment on Issue #2528:

I implemented your suggestion, the code definitely is more elegant this way.

I also added a _private field to the error for extensibility and moved the test to tests/all/externals.rs since most tests seem to live there.

Wasmtime GitHub notifications bot (Jan 26 2021 at 15:09):

alexcrichton commented on Issue #2528:

Looks great to me, thanks!

Last updated: Dec 23 2024 at 12:05 UTC