wasmtime / Issue #2523 Add test for filestat_get for stdio · git-wasmtime

Stream: git-wasmtime

Topic: wasmtime / Issue #2523 Add test for filestat_get for stdio

Wasmtime GitHub notifications bot (Dec 18 2020 at 13:11):

@pchickey

Wasmtime GitHub notifications bot (Dec 18 2020 at 13:56):

github-actions[bot] commented on Issue #2523:

Subscribe to Label Action

cc @kubkon

<details>
This issue or pull request has been labeled: "wasi"

Thus the following users have been cc'd because of the following labels:

kubkon: wasi

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Dec 18 2020 at 14:18):

sakarias88 commented on Issue #2523:

We will fix the CI failures once we get our hands on a windows machine.

Wasmtime GitHub notifications bot (Jan 14 2021 at 13:42):

abbec commented on Issue #2523:

"Fixing up" fstat for Windows brought a question. It seems that the fstat implementation for Windows returns a lot of OS-specific information causing a WASI fstat call to behave differently depending on host OS. I thought the intention was that fstat for example was supposed to return information from a "WASI" perspective. I.e. for example the inode number would be an "emulated" inode number that is the same on both Unix and Windows hosts (which is not the case in Wasmtime currently but it is in Wasmer)?

Wasmtime GitHub notifications bot (Jan 14 2021 at 13:54):

abbec edited a comment on Issue #2523:

"Fixing up" fstat for Windows brought a question. It seems that the fstat implementation for Windows returns a lot of OS-specific information causing a WASI fstat call to behave differently depending on host OS. I thought the intention was that fstat for example was supposed to return information from a "WASI" perspective. I.e. for example the inode number would be an "emulated" inode number that is the same on both Unix and Windows hosts (which is not the case in Wasmtime currently but it is in Wasmer)? Not that doing logic on the inode number is very likely but hey :big_smile:

Wasmtime GitHub notifications bot (Jan 14 2021 at 13:55):

abbec edited a comment on Issue #2523:

"Fixing up" fstat for Windows brought a question. It seems that the fstat implementation for Windows returns a lot of OS-specific information causing a WASI fstat call to behave differently depending on host OS. I thought the intention was that fstat for example was supposed to return information from a "WASI" perspective. I.e. for example the inode number would be an "emulated" inode number that is the same on both Unix and Windows hosts (which is not the case in Wasmtime currently but it is in Wasmer)? Not that doing logic on the inode number is very likely but anyway :big_smile:

Last updated: Nov 22 2024 at 17:03 UTC