Stream: git-wasmtime

Topic: wasmtime / Issue #2501 2499: First pass on TableOps fuzze...

Wasmtime GitHub notifications bot (Dec 15 2020 at 22:54):

dhaynespls commented on Issue #2501:

Looks great! Two tiny nitpicks and then this should be good to merge!

Nice, applied. Love this github feature!

Wasmtime GitHub notifications bot (Dec 15 2020 at 23:50):

fitzgen commented on Issue #2501:

Looks like there is another place further down that needs to be updated since the variable name changed:

error[E0425]: cannot find value `wat` in this scope
   --> crates/fuzzing/src/oracles.rs:423:50
    |
423 |         let module = match Module::new(&engine, &wat) {
    |                                                  ^^^ not found in this scope

Wasmtime GitHub notifications bot (Dec 16 2020 at 00:17):

dhaynespls commented on Issue #2501:

Ah yeah, should have checked locally.

Do we care that this is dead code now?

  --> crates/fuzzing/src/oracles.rs:43:4
   |
43 | fn log_wat(wat: &str) {
   |    ^^^^^^^
   |
   = note: `#[warn(dead_code)]` on by default
   ```
~~~

Wasmtime GitHub notifications bot (Dec 16 2020 at 00:36):

fitzgen commented on Issue #2501:

Yeah let's go ahead and remove that too. Thanks!

Wasmtime GitHub notifications bot (Dec 17 2020 at 17:21):

dhaynespls commented on Issue #2501:

Removed! Let me know if I need to do anything else in order to merge!

Wasmtime GitHub notifications bot (Dec 17 2020 at 21:47):

alexcrichton commented on Issue #2501:

Looks great to me, thanks @dhaynespls! I think fitzgen is enjoying the great outdoors now so I'll go ahead and merge.

Last updated: Oct 23 2024 at 20:03 UTC