dhaynespls commented on Issue #2501:
Looks great! Two tiny nitpicks and then this should be good to merge!
Nice, applied. Love this github feature!
fitzgen commented on Issue #2501:
Looks like there is another place further down that needs to be updated since the variable name changed:
error[E0425]: cannot find value `wat` in this scope --> crates/fuzzing/src/oracles.rs:423:50 | 423 | let module = match Module::new(&engine, &wat) { | ^^^ not found in this scope
dhaynespls commented on Issue #2501:
Ah yeah, should have checked locally.
Do we care that this is dead code now?
--> crates/fuzzing/src/oracles.rs:43:4 | 43 | fn log_wat(wat: &str) { | ^^^^^^^ | = note: `#[warn(dead_code)]` on by default ``` ~~~
fitzgen commented on Issue #2501:
Yeah let's go ahead and remove that too. Thanks!
dhaynespls commented on Issue #2501:
Removed! Let me know if I need to do anything else in order to merge!
alexcrichton commented on Issue #2501:
Looks great to me, thanks @dhaynespls! I think fitzgen is enjoying the great outdoors now so I'll go ahead and merge.
Last updated: Dec 23 2024 at 13:07 UTC