Stream: git-wasmtime

Topic: wasmtime / Issue #2490 x64 lowering fix: i32.popcnt shoul...

Wasmtime GitHub notifications bot (Dec 09 2020 at 06:28):

cfallin commented on Issue #2490:

Thanks!

Is this problem an isolated case, or could it potentially affect other load-op merges?

I looked at all the other input_to_reg_mem() callsites and I don't see any other instances of this problem. That said, I'll consider if there's a way to work this into the types somehow -- perhaps input_to_reg_mem() either takes an operand size and asserts it's as expected, or returns a mem op only if the load would be the right size, or something like that... I don't want to block this PR landing on it but will think further!

Last updated: Oct 23 2024 at 20:03 UTC