alexcrichton commented on Issue #2481:
I believe the failures here are for wasmparser to fix -- https://github.com/bytecodealliance/wasm-tools/pull/164
alexcrichton commented on Issue #2481:
Ok I've published 0.69.2
abrown commented on Issue #2481:
@alexcrichton, @fitzgen: I went with
0.69
in theCargo.toml
files and locked it to0.69.2
in theCargo.lock
--is that the right choice?Also, if we update
object
to use wasmparser's0.69
then we would have the same version ofwasmparser
used everywhere in the project. Right nowobject
is still looking back at0.57
.
alexcrichton commented on Issue #2481:
Ideally one lock file would mentione 0.69.2 to indicate that we require at least that version, but otherwise seems fine!
alexcrichton edited a comment on Issue #2481:
Ideally one
lockmanifest file would mentione 0.69.2 to indicate that we require at least that version, but otherwise seems fine!
fitzgen commented on Issue #2481:
I personally prefer to update the
.toml
to the minor version, just so that I don't have to do different things depending on if I'm in a project that has a committed lock file or not.It would be nice to update
object
so that we only have one copy ofwasmparser
but seems orthogonal to this work.
github-actions[bot] commented on Issue #2481:
Subscribe to Label Action
cc @fitzgen, @peterhuene
<details>
This issue or pull request has been labeled: "cranelift", "cranelift:wasm", "fuzzing", "lightbeam", "wasmtime:api"Thus the following users have been cc'd because of the following labels:
- fitzgen: fuzzing
- peterhuene: wasmtime:api
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Last updated: Dec 23 2024 at 12:05 UTC