Stream: git-wasmtime

Topic: wasmtime / Issue #2481 Update spec tests

view this post on Zulip Wasmtime GitHub notifications bot (Dec 07 2020 at 15:52):

alexcrichton commented on Issue #2481:

I believe the failures here are for wasmparser to fix -- https://github.com/bytecodealliance/wasm-tools/pull/164

view this post on Zulip Wasmtime GitHub notifications bot (Dec 07 2020 at 16:34):

alexcrichton commented on Issue #2481:

Ok I've published 0.69.2

view this post on Zulip Wasmtime GitHub notifications bot (Dec 07 2020 at 17:22):

abrown commented on Issue #2481:

@alexcrichton, @fitzgen: I went with 0.69 in the Cargo.toml files and locked it to 0.69.2 in the Cargo.lock--is that the right choice?

Also, if we update object to use wasmparser's 0.69 then we would have the same version of wasmparser used everywhere in the project. Right now object is still looking back at 0.57.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 07 2020 at 17:24):

alexcrichton commented on Issue #2481:

Ideally one lock file would mentione 0.69.2 to indicate that we require at least that version, but otherwise seems fine!

view this post on Zulip Wasmtime GitHub notifications bot (Dec 07 2020 at 17:34):

alexcrichton edited a comment on Issue #2481:

Ideally one lock manifest file would mentione 0.69.2 to indicate that we require at least that version, but otherwise seems fine!

view this post on Zulip Wasmtime GitHub notifications bot (Dec 07 2020 at 17:35):

fitzgen commented on Issue #2481:

I personally prefer to update the .toml to the minor version, just so that I don't have to do different things depending on if I'm in a project that has a committed lock file or not.

It would be nice to update object so that we only have one copy of wasmparser but seems orthogonal to this work.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 07 2020 at 18:38):

github-actions[bot] commented on Issue #2481:

Subscribe to Label Action

cc @fitzgen, @peterhuene

<details>
This issue or pull request has been labeled: "cranelift", "cranelift:wasm", "fuzzing", "lightbeam", "wasmtime:api"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Last updated: Nov 22 2024 at 16:03 UTC