Stream: git-wasmtime

Topic: wasmtime / Issue #2468 Improve usability of constants

Wasmtime GitHub notifications bot (Dec 02 2020 at 22:56):

abrown commented on Issue #2468:

@cfallin, @bnjbvr, I think this almost wraps up what I had proposed in #1385. Several caveats:

• I chose to not replace all of the ctx.emit(PXOR...) uses with ctx.emit_constant([0; 16]...) because I was concerned there might be an extra allocation or extra logic that might slightly slow down compile times; if you don't think this is the case and want a consistent way of generating constants, I can do the replacement here
• I have not dug into removing LowerCtx::get_constant (its uses can all be replaced by LowerCtx::get_immediate) and the LowerInput::constant field--I can do that as a part of this PR but wanted to get feedback on the current changes first

Wasmtime GitHub notifications bot (Dec 02 2020 at 23:20):

abrown commented on Issue #2468:

(And apparently CI will fail until I figure out the LowerCtx::get_constant and LowerInput::constant issues: do we want to go down that route?)

Wasmtime GitHub notifications bot (Dec 02 2020 at 23:21):

abrown edited a comment on Issue #2468:

(And apparently CI will fail until I figure out the LowerCtx::get_constant and LowerInput::constant issues: do we want to go down the route to remove those?)

Last updated: Dec 23 2024 at 13:07 UTC