Stream: git-wasmtime

Topic: wasmtime / Issue #2467 Audit needed of instructions that ...

view this post on Zulip Wasmtime GitHub notifications bot (Dec 02 2020 at 21:40):

jlb6740 opened Issue #2467:

I know this isn't part of the PR, but it is curious that these are implemented as lib calls instead of using ROUNDSD and ROUNDSS--@bnjbvr, do you know why this is? I wonder if there is some NaN handling there that we should also be doing for the packed version...

_Originally posted by @abrown in https://github.com/bytecodealliance/wasmtime/pull/2457#discussion_r534339371_

view this post on Zulip Wasmtime GitHub notifications bot (Dec 02 2020 at 21:40):

jlb6740 edited Issue #2467:

I know this isn't part of the PR, but it is curious that these are implemented as lib calls instead of using ROUNDSD and ROUNDSS--@bnjbvr, do you know why this is? I wonder if there is some NaN handling there that we should also be doing for the packed version...

_Originally posted by @abrown in https://github.com/bytecodealliance/wasmtime/pull/2457#discussion_r534339371_

view this post on Zulip Wasmtime GitHub notifications bot (Dec 02 2020 at 21:40):

jlb6740 assigned Issue #2467:

I know this isn't part of the PR, but it is curious that these are implemented as lib calls instead of using ROUNDSD and ROUNDSS--@bnjbvr, do you know why this is? I wonder if there is some NaN handling there that we should also be doing for the packed version...

_Originally posted by @abrown in https://github.com/bytecodealliance/wasmtime/pull/2457#discussion_r534339371_

view this post on Zulip Wasmtime GitHub notifications bot (Jan 27 2021 at 16:08):

bnjbvr labeled Issue #2467 (assigned to jlb6740):

I know this isn't part of the PR, but it is curious that these are implemented as lib calls instead of using ROUNDSD and ROUNDSS--@bnjbvr, do you know why this is? I wonder if there is some NaN handling there that we should also be doing for the packed version...

_Originally posted by @abrown in https://github.com/bytecodealliance/wasmtime/pull/2457#discussion_r534339371_

view this post on Zulip Wasmtime GitHub notifications bot (Jan 27 2021 at 16:08):

bnjbvr labeled Issue #2467 (assigned to jlb6740):

I know this isn't part of the PR, but it is curious that these are implemented as lib calls instead of using ROUNDSD and ROUNDSS--@bnjbvr, do you know why this is? I wonder if there is some NaN handling there that we should also be doing for the packed version...

_Originally posted by @abrown in https://github.com/bytecodealliance/wasmtime/pull/2457#discussion_r534339371_

Last updated: Dec 23 2024 at 12:05 UTC