github-actions[bot] commented on Issue #2454:
Subscribe to Label Action
cc @peterhuene
<details>
This issue or pull request has been labeled: "cranelift", "cranelift:wasm", "wasmtime:api"Thus the following users have been cc'd because of the following labels:
- peterhuene: wasmtime:api
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
peterhuene commented on Issue #2454:
This PR also tries to reduce allocations and copying:
wasmtime_environ::Module
now stores passive element and data segments differently so that instances can track dropped segments using anEntitySet
rather than cloning the previousHashMap
s and removing an entry when dropped.The
module
field ofCompilationArtifacts
have been madeArc
so thatCompiledModule
doesn't need to clone the underlying module during compilation.Similarly, the
data_initializers
field ofCompilationArtifacts
has been madeArc
so that, in the future, a pooling instance allocator can take a reference on the data initializers for on-demand initialization of linear memory pages. This change also prevents having to allocate a newVec
of data initializers to complete initialization for every instantiation.
github-actions[bot] commented on Issue #2454:
Subscribe to Label Action
cc @peterhuene
<details>
This issue or pull request has been labeled: "wasmtime:c-api"Thus the following users have been cc'd because of the following labels:
- peterhuene: wasmtime:c-api
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
peterhuene commented on Issue #2454:
Closing this PR in favor of #2518.
Last updated: Nov 22 2024 at 16:03 UTC