Stream: git-wasmtime

Topic: wasmtime / Issue #2400 Specify unsealed / unfilled blocks

view this post on Zulip Wasmtime GitHub notifications bot (Nov 17 2020 at 02:46):

MattX commented on Issue #2400:

Thanks for the review! Maybe I'm missing something, but I've gated the loop with #[cfg(debug_assertions)], so as far as I know this assertion should be run exactly when the debug_assert! would run. I don't think there should be any significant performance difference.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 17 2020 at 06:43):

fitzgen commented on Issue #2400:

D’oh I completely missed the cfg

view this post on Zulip Wasmtime GitHub notifications bot (Nov 20 2020 at 20:29):

MattX commented on Issue #2400:

@fitzgen Any opinion for or against merging this?

view this post on Zulip Wasmtime GitHub notifications bot (Nov 20 2020 at 21:23):

fitzgen commented on Issue #2400:

(Sorry for the delay!)

view this post on Zulip Wasmtime GitHub notifications bot (Nov 21 2020 at 17:09):

MattX commented on Issue #2400:

Awesome! Yeah I completely forgot about assert! for some reason.

Last updated: Nov 22 2024 at 16:03 UTC