Stream: git-wasmtime

Topic: wasmtime / Issue #2377 Minimum Rust badge seems incorrect

view this post on Zulip Wasmtime GitHub notifications bot (Nov 08 2020 at 09:30):

Voultapher opened Issue #2377:

Just tried building the cranelift tests with cd cranelift && cargo test --all using Rust 1.44 and it failed building one of the dependencies because it wanted to use this https://github.com/alexcrichton/proc-macro2/pull/228. After upgrading to 1.47 everything works as expected. The top level README has a Rust 1.37+ badge. Either that is wrong or misleading.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 08 2020 at 10:25):

Voultapher edited Issue #2377:

Just tried building the cranelift tests with cd cranelift && cargo test --all using Rust 1.44 and it failed building one of the dependencies because it wanted to use this https://github.com/alexcrichton/proc-macro2/pull/228. After upgrading to 1.47 everything works as expected. The top level README has a Rust 1.37+ badge. Either that is wrong or misleading.

Edit: Actually I need nightly to run the tests. I suggest we put that in the relevant README.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 08 2020 at 10:25):

Voultapher edited Issue #2377:

Just tried building the cranelift tests with cd cranelift && cargo test --all using Rust 1.44 and it failed building one of the dependencies because it wanted to use this https://github.com/alexcrichton/proc-macro2/pull/228. After upgrading to 1.47 everything works as expected. The top level README has a Rust 1.37+ badge. Either that is wrong or misleading.

Edit: Actually I need nightly to build and run the tests. I suggest we put that in the relevant README.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 09 2020 at 15:17):

alexcrichton commented on Issue #2377:

Ah yes I think that's a mistake, sorry about that! A PR would be welcome to clarify and update this!

Last updated: Dec 23 2024 at 12:05 UTC