Stream: git-wasmtime

Topic: wasmtime / Issue #2366 MachInst lowering logic: allow eff...

Wasmtime GitHub notifications bot (Nov 11 2020 at 17:55):

cfallin commented on Issue #2366:

Any volunteers to review? @julian-seward1 has let me know he's deep in fire-fighting at the moment; @fitzgen or @peterhuene perhaps?

Wasmtime GitHub notifications bot (Nov 11 2020 at 23:51):

fitzgen commented on Issue #2366:

I can review this if no one else with expertise in this part of the code base has time.

Quick question: will this (eventually) enable collapsing

v0 = load.i32 $addr
v1 = iadd_imm v0, 1
store v0, $addr

into

add $addr, 1

on x64? We emit clif like that in our refcounting gc barriers for externrefs right now >.<

Wasmtime GitHub notifications bot (Nov 12 2020 at 00:26):

cfallin commented on Issue #2366:

@fitzgen Thanks very much!

Quick question: will this (eventually) enable collapsing

v0 = load.i32 $addr v1 = iadd_imm v0, 1 store v0, $addr

into

add $addr, 1

on x64? We emit clif like that in our refcounting gc barriers for externrefs right now >.<

Indeed, that's possible to build once this lands; it would be the next step after #2389 (which so far just merges the load and add).

Last updated: Nov 22 2024 at 16:03 UTC