Wasmtime GitHub notifications bot (Nov 02 2020 at 19:17): Wasmtime GitHub notifications bot (Nov 02 2020 at 19:17):cfallin commented on Issue #2352:
I think this should fix the CI failure in #2345.
Wasmtime GitHub notifications bot (Nov 02 2020 at 21:03):alexcrichton commented on Issue #2352:
Hm so in theory
--lockedhas no user-visible effect other than returning errors instead of downloading new things, but if aCargo.lockexists and works then--locked-or-not in theory should be the same. I've seen this issue crop up a few times (the one on #2345), and I suspect it may be a bug in Cargo, so if it shows up even with this added let me know and I can try to dig in more.
Wasmtime GitHub notifications bot (Nov 02 2020 at 21:26):cfallin commented on Issue #2352:
Ah, I see, I had misunderstood what the flag does, then; though I suppose it doesn't hurt to use it here if we use it for other runs?
Of note is that this build does turn on the new crate-version resolver (?) with
-Zpackage-features-- if it is a bug I would guess that could be the reason we see it. Perhaps we could instead create a root-level feature to enable the new x64 backend and get this working without the Cargo feature -- or do you suspect the bug would still be hit?
Wasmtime GitHub notifications bot (Nov 02 2020 at 23:25):alexcrichton commented on Issue #2352:
Yeah if anything I suspect a bug with
-Zpackage-featuresrather than in Wasmtime or our CI, I just haven't ever dug in!
Wasmtime GitHub notifications bot (Nov 03 2020 at 02:29):alexcrichton commented on Issue #2352:
Ah after some testing locally this is a bug that was fixed in Cargo, but we're pinned to an older nightly so we don't have it fixed yet. I'll send a PR update.
Last updated: Nov 22 2024 at 17:03 UTC