Stream: git-wasmtime

Topic: wasmtime / Issue #2326 Remove Windows-specific code for s...

view this post on Zulip Wasmtime GitHub notifications bot (Oct 27 2020 at 03:44):

alexcrichton commented on Issue #2326:

cc @sunfishcode and @peterhuene, I'm not sure whether this is still needed any more, but I'm curious if y'all know more!

view this post on Zulip Wasmtime GitHub notifications bot (Oct 27 2020 at 04:04):

whitequark commented on Issue #2326:

causing runtime and compile-time slowdowns on Windows-only.

Oh huh, so I wasn't imagining the slowdown! Thanks for fixing it.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 27 2020 at 04:18):

github-actions[bot] commented on Issue #2326:

Subscribe to Label Action

cc @peterhuene

<details>
This issue or pull request has been labeled: "wasmtime:api"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (Oct 27 2020 at 04:18):

peterhuene commented on Issue #2326:

I don't know the background to the original change as it was unfortunately before my time.

As it is referencing the page file, all I can think of is that the Windows implementation was originally allocating the memory committed instead of reserved?

I think that was the case given this old code.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 27 2020 at 04:20):

peterhuene commented on Issue #2326:

Let's let @sunfishcode weigh in before merging this as he originally added this restriction.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 27 2020 at 04:20):

peterhuene edited a comment on Issue #2326:

Let's let @sunfishcode weigh-in before merging this as he originally added this restriction.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 28 2020 at 23:49):

sunfishcode commented on Issue #2326:

Looks good to me! We have much better Windows support and testing now than we did at that time, so now if we ever run out of resources, we're in a much better position now to find it and understand what's happening.

Last updated: Nov 22 2024 at 16:03 UTC