Stream: git-wasmtime

Topic: wasmtime / Issue #2320 Convert packed floating point to s...

Wasmtime GitHub notifications bot (Oct 27 2020 at 01:00):

jlb6740 commented on Issue #2320:

Hopefully all issues have been addressed, but let me know if there is anything else.

Wasmtime GitHub notifications bot (Oct 28 2020 at 18:58):

bnjbvr commented on Issue #2320:

LGTM, see comments. @cfallin, any thoughts on a way to determine what SSE features are available during lowering?

X64Backend has a x64_flags field which contains this information, e.g. has_sse42() (as derived from the meta, x64 target-specific settings file); you could access it by changing slightly the signature of lower_insn_to_regs and passing it the self.x64_flags next to the self.flags.

Wasmtime GitHub notifications bot (Oct 28 2020 at 19:03):

jlb6740 commented on Issue #2320:

LGTM, see comments. @cfallin, any thoughts on a way to determine what SSE features are available during lowering?

X64Backend has a x64_flags field which contains this information, e.g. has_sse42() (as derived from the meta, x64 target-specific settings file); you could access it by changing slightly the signature of lower_insn_to_regs and passing it the self.x64_flags next to the self.flags.

Looks like it is already a parameter, it's just a matter of using it.

Wasmtime GitHub notifications bot (Oct 28 2020 at 19:04):

jlb6740 deleted a comment on Issue #2320:

LGTM, see comments. @cfallin, any thoughts on a way to determine what SSE features are available during lowering?

X64Backend has a x64_flags field which contains this information, e.g. has_sse42() (as derived from the meta, x64 target-specific settings file); you could access it by changing slightly the signature of lower_insn_to_regs and passing it the self.x64_flags next to the self.flags.

Looks like it is already a parameter, it's just a matter of using it.

Last updated: Oct 23 2024 at 20:03 UTC