Stream: git-wasmtime

Topic: wasmtime / Issue #2309 Add Trap::trap_code

view this post on Zulip Wasmtime GitHub notifications bot (Oct 22 2020 at 16:33):

github-actions[bot] commented on Issue #2309:

Subscribe to Label Action

cc @peterhuene

<details>
This issue or pull request has been labeled: "wasmtime:api"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (Oct 23 2020 at 15:35):

alexcrichton commented on Issue #2309:

Thanks for the PR! I don't think we'll want to expose the cranelift-internal TrapCode as part of the public API of the wasmtime crate, though. That's an internal implementation detail of wasmtime, so I think it'd be best to instead have a public #[non_exhaustive] enum perhaps defined in wasmtime itself?

view this post on Zulip Wasmtime GitHub notifications bot (Oct 23 2020 at 21:29):

leoyvens commented on Issue #2309:

@alexcrichton That's a good suggestion, for my personal use case I'd prefer that it were exhaustive but I get that for versioning it's best for it to not be.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 27 2020 at 17:02):

leoyvens commented on Issue #2309:

@alexcrichton Thanks for the speedy review, I've addressed all suggested changes.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 27 2020 at 20:44):

leoyvens commented on Issue #2309:

@alexcrichton Done!

view this post on Zulip Wasmtime GitHub notifications bot (Oct 27 2020 at 21:30):

alexcrichton commented on Issue #2309:

Thanks again for this!

Last updated: Nov 22 2024 at 16:03 UTC