github-actions[bot] commented on Issue #2309:
Subscribe to Label Action
cc @peterhuene
<details>
This issue or pull request has been labeled: "wasmtime:api"Thus the following users have been cc'd because of the following labels:
- peterhuene: wasmtime:api
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
alexcrichton commented on Issue #2309:
Thanks for the PR! I don't think we'll want to expose the cranelift-internal
TrapCode
as part of the public API of thewasmtime
crate, though. That's an internal implementation detail of wasmtime, so I think it'd be best to instead have a public#[non_exhaustive]
enum perhaps defined inwasmtime
itself?
leoyvens commented on Issue #2309:
@alexcrichton That's a good suggestion, for my personal use case I'd prefer that it were exhaustive but I get that for versioning it's best for it to not be.
leoyvens commented on Issue #2309:
@alexcrichton Thanks for the speedy review, I've addressed all suggested changes.
leoyvens commented on Issue #2309:
@alexcrichton Done!
alexcrichton commented on Issue #2309:
Thanks again for this!
Last updated: Dec 23 2024 at 12:05 UTC