Stream: git-wasmtime

Topic: wasmtime / Issue #2308 CL/aarch64 back end: implement the...

Wasmtime GitHub notifications bot (Oct 22 2020 at 15:47):

julian-seward1 commented on Issue #2308:

@yurydelendik test-mention.

Wasmtime GitHub notifications bot (Oct 23 2020 at 02:54):

julian-seward1 commented on Issue #2308:

Thanks for the review. A couple of comments:

Also, is there an extra "preopt.serialized" that needs to be removed?

That is something to do with peepmatic -- a generated file, resulting from the change of the CLIF instruction-definition file.

there is no need to implement all VecShiftImmOp, only SShr is needed

That's true; but it was easy enough to implement and test UShr and Shl too. I thought these would be useful. In particular, for doing improved translations of CLIF vector shifts by immediate, at some future point.

Last updated: Nov 22 2024 at 17:03 UTC