Stream: git-wasmtime

Topic: wasmtime / Issue #2287 Some SimpleJIT improvements

Wasmtime GitHub notifications bot (Oct 12 2020 at 10:00):

bjorn3 commented on Issue #2287:

r? @pchickey

Wasmtime GitHub notifications bot (Oct 12 2020 at 12:13):

bjorn3 commented on Issue #2287:

I noticed that the stack map code in SimpleJIT doesn't export anything to the user. Should I remove it or make it accessible to the user?

Wasmtime GitHub notifications bot (Oct 12 2020 at 12:48):

bjorn3 commented on Issue #2287:

"CI / Test x64 new backend" failure is unrelated I think:

<details>

error[E0277]: the trait bound `wiggle_generate::config::Paths: syn::parse::Parse` is not satisfied
   --> crates/wiggle/wasmtime/macro/src/config.rs:53:50
    |
53  |             Ok(ConfigField::Witx(WitxConf::Paths(input.parse()?)))
    |                                                  ^^^^^^^^^^^^^^ the trait `syn::parse::Parse` is not implemented for `wiggle_generate::config::Paths`
    |
help: trait impl with same name found
   --> /home/runner/work/wasmtime/wasmtime/crates/wiggle/generate/src/config.rs:182:1
    |
182 | / impl Parse for Paths {
183 | |     fn parse(input: ParseStream) -> Result<Self> {
184 | |         let content;
185 | |         let _ = bracketed!(content in input);
...   |
200 | |     }
201 | | }
    | |_^
    = note: perhaps two different versions of crate `syn` are being used?

error[E0277]: the trait bound `wiggle_generate::config::Literal: syn::parse::Parse` is not satisfied
   --> crates/wiggle/wasmtime/macro/src/config.rs:57:52
    |
57  |             Ok(ConfigField::Witx(WitxConf::Literal(input.parse()?)))
    |                                                    ^^^^^^^^^^^^^^ the trait `syn::parse::Parse` is not implemented for `wiggle_generate::config::Literal`
    |
help: trait impl with same name found
   --> /home/runner/work/wasmtime/wasmtime/crates/wiggle/generate/src/config.rs:213:1
    |
213 | / impl Parse for Literal {
214 | |     fn parse(input: ParseStream) -> Result<Self> {
215 | |         Ok(Self(input.parse::<syn::LitStr>()?.value()))
216 | |     }
217 | | }
    | |_^
    = note: perhaps two different versions of crate `syn` are being used?

error[E0277]: the trait bound `wiggle_generate::config::CtxConf: syn::parse::Parse` is not satisfied
   --> crates/wiggle/wasmtime/macro/src/config.rs:61:33
    |
61  |             Ok(ConfigField::Ctx(input.parse()?))
    |                                 ^^^^^^^^^^^^^^ the trait `syn::parse::Parse` is not implemented for `wiggle_generate::config::CtxConf`
    |
help: trait impl with same name found
   --> /home/runner/work/wasmtime/wasmtime/crates/wiggle/generate/src/config.rs:224:1
    |
224 | / impl Parse for CtxConf {
225 | |     fn parse(input: ParseStream) -> Result<Self> {
226 | |         Ok(CtxConf {
227 | |             name: input.parse()?,
228 | |         })
229 | |     }
230 | | }
    | |_^
    = note: perhaps two different versions of crate `syn` are being used?

error: aborting due to 3 previous errors

For more information about this error, try `rustc --explain E0277`.
error: could not compile `wasmtime-wiggle-macro`.

</details>

Wasmtime GitHub notifications bot (Oct 12 2020 at 13:17):

bnjbvr commented on Issue #2287:

"CI / Test x64 new backend" failure is unrelated I think:

Yep, that's an intermittent build failure i've been observing; retriggering the job is usually sufficient. cc @alexcrichton in case you have an idea of what could have caused this?

Wasmtime GitHub notifications bot (Oct 12 2020 at 13:24):

bjorn3 commented on Issue #2287:

Failed again.

Wasmtime GitHub notifications bot (Oct 12 2020 at 21:25):

alexcrichton commented on Issue #2287:

I saw that awhile ago as well for whatever reason, unsure what's happening thought. I'd recommend updating the pinned nightly and see if it's a Cargo bug that's been fixed.

Wasmtime GitHub notifications bot (Oct 27 2020 at 15:06):

bjorn3 commented on Issue #2287:

Friendly ping @pchickey

Last updated: Nov 22 2024 at 16:03 UTC