yurydelendik commented on Issue #2266:
I don't see how
stackmaps
in theCodeSink
are populated. Keeping tests in "tests/all/gc.rs" disabled.
yurydelendik edited a comment on Issue #2266:
I don't see how
stackmaps
in theCodeSink
are populated (for machinst). Keeping tests in "tests/all/gc.rs" disabled.
yurydelendik commented on Issue #2266:
not to use UnwindInfoKind?
make unwind info available without feature?Cannot find solutions to address these two -- open for suggestions. Opening for review.
peterhuene commented on Issue #2266:
I also have no strong opinion on removal of the
unwind
feature. I would probably favor keeping it at this point.Regarding
UnwindInfoKind
, I would probably remove it if possible as I don't see much of a use case for generating unwind information in a different format than the function's (ABI-specific) calling convention.
bjorn3 commented on Issue #2266:
macOS has both DWARF unwinding and compact unwind info. Both of which can be used with the same SystemV calling convention.
peterhuene commented on Issue #2266:
I'm :+1: with keeping it.
yurydelendik commented on Issue #2266:
merged with #2307 changes: that allowed to replace "mov reg, imm(rsp)" todo -- carrying over the review approval
Last updated: Dec 23 2024 at 12:05 UTC