Stream: git-wasmtime

Topic: wasmtime / Issue #2253 Problems with the C API header


view this post on Zulip Wasmtime GitHub notifications bot (Oct 01 2020 at 21:26):

DagAgren opened Issue #2253:

Using the latest macOS release (https://github.com/bytecodealliance/wasmtime/releases/download/v0.20.0/wasmtime-v0.20.0-x86_64-macos-c-api.tar.xz):

Some of the function defines, like WASM_API_EXTERN own wasm_config_t* wasm_config_new(); are not quite correct, and should use (void) for the arguments. () works, but defines a function with undeclared arguments, rather than with no arguments. Xcode, at least, will by default warn on this:

.../wasm.h:121:51: This function declaration is not a prototype

view this post on Zulip Wasmtime GitHub notifications bot (Oct 01 2020 at 21:26):

DagAgren labeled Issue #2253:

Using the latest macOS release (https://github.com/bytecodealliance/wasmtime/releases/download/v0.20.0/wasmtime-v0.20.0-x86_64-macos-c-api.tar.xz):

Some of the function defines, like WASM_API_EXTERN own wasm_config_t* wasm_config_new(); are not quite correct, and should use (void) for the arguments. () works, but defines a function with undeclared arguments, rather than with no arguments. Xcode, at least, will by default warn on this:

.../wasm.h:121:51: This function declaration is not a prototype

view this post on Zulip Wasmtime GitHub notifications bot (Oct 01 2020 at 21:40):

abrown labeled Issue #2253:

Using the latest macOS release (https://github.com/bytecodealliance/wasmtime/releases/download/v0.20.0/wasmtime-v0.20.0-x86_64-macos-c-api.tar.xz):

Some of the function defines, like WASM_API_EXTERN own wasm_config_t* wasm_config_new(); are not quite correct, and should use (void) for the arguments. () works, but defines a function with undeclared arguments, rather than with no arguments. Xcode, at least, will by default warn on this:

.../wasm.h:121:51: This function declaration is not a prototype

view this post on Zulip Wasmtime GitHub notifications bot (Oct 01 2020 at 21:40):

github-actions[bot] commented on Issue #2253:

Subscribe to Label Action

cc @peterhuene

<details>
This issue or pull request has been labeled: "wasmtime:c-api"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (Oct 01 2020 at 22:47):

alexcrichton commented on Issue #2253:

Thanks for the report! This isn't actually a header which we define in this repository, it's located upstream at https://github.com/WebAssembly/wasm-c-api, so that's where the fix will need to land first for us to pull it in.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 02 2020 at 09:02):

DagAgren commented on Issue #2253:

Submitted https://github.com/WebAssembly/wasm-c-api/issues/154.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 03 2020 at 13:49):

Hywan commented on Issue #2253:

I've fixed it for you, https://github.com/WebAssembly/wasm-c-api/pull/160 :-).

view this post on Zulip Wasmtime GitHub notifications bot (Feb 03 2021 at 20:50):

bjorn3 commented on Issue #2253:

https://github.com/WebAssembly/wasm-c-api/pull/160 has been merged.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 03 2021 at 20:52):

cfallin closed Issue #2253:

Using the latest macOS release (https://github.com/bytecodealliance/wasmtime/releases/download/v0.20.0/wasmtime-v0.20.0-x86_64-macos-c-api.tar.xz):

Some of the function defines, like WASM_API_EXTERN own wasm_config_t* wasm_config_new(); are not quite correct, and should use (void) for the arguments. () works, but defines a function with undeclared arguments, rather than with no arguments. Xcode, at least, will by default warn on this:

.../wasm.h:121:51: This function declaration is not a prototype

Last updated: Nov 22 2024 at 17:03 UTC