Stream: git-wasmtime

Topic: wasmtime / Issue #2239 Cranelift filetests are not runnab...

view this post on Zulip Wasmtime GitHub notifications bot (Sep 28 2020 at 19:27):

abrown opened Issue #2239:

#2226 enabled Cranelift filetests but this functionality seems unavailable from the CLI:

$ cargo run --color=always --features experimental_x64 -p cranelift-tools -- test cranelift/filetests/filetests/isa/x64
    Finished dev [unoptimized + debuginfo] target(s) in 0.07s
     Running `target/debug/clif-util test cranelift/filetests/filetests/isa/x64`
skipped "cranelift/filetests/filetests/isa/x64/basic.clif": missing support for experimental_x64
skipped "cranelift/filetests/filetests/isa/x64/run-const.clif": missing support for experimental_x64
skipped "cranelift/filetests/filetests/isa/x64/simd-lane-access-compile.clif": missing support for experimental_x64
skipped "cranelift/filetests/filetests/isa/x64/simd-lane-access-run.clif": missing support for experimental_x64
4 tests

view this post on Zulip Wasmtime GitHub notifications bot (Sep 28 2020 at 19:27):

abrown commented on Issue #2239:

cc: @bnjbvr

view this post on Zulip Wasmtime GitHub notifications bot (Sep 28 2020 at 19:32):

abrown commented on Issue #2239:

Also, and probably related, the following does not work:

cargo test --color=always --features experimental_x64 -p cranelift-tools --test filetests filetests

view this post on Zulip Wasmtime GitHub notifications bot (Sep 29 2020 at 09:54):

bnjbvr commented on Issue #2239:

It seems to work fine on my end, even after a git pull and a cargo clean:

➜ cargo run --color=always --features experimental_x64 -p cranelift-tools -- test -vd ./filetests/filetests/isa/x64
    Finished dev [unoptimized + debuginfo] target(s) in 0.05s
     Running `/home/ben/code/wasmtime/target/debug/clif-util test -vd ./filetests/filetests/isa/x64`
0.016 ./filetests/filetests/isa/x64/basic.clif
0.005 ./filetests/filetests/isa/x64/run-const.clif
2 tests

I'm happy to help debugging this over chat. Alternatively, you can use the top-level CI script to run filetests, as long as you have the Nightly toolchain installed: ./ci/run-experimental-x64-ci.sh -- filetests

view this post on Zulip Wasmtime GitHub notifications bot (Sep 29 2020 at 09:54):

bnjbvr labeled Issue #2239:

#2226 enabled Cranelift filetests but this functionality seems unavailable from the CLI:

$ cargo run --color=always --features experimental_x64 -p cranelift-tools -- test cranelift/filetests/filetests/isa/x64
    Finished dev [unoptimized + debuginfo] target(s) in 0.07s
     Running `target/debug/clif-util test cranelift/filetests/filetests/isa/x64`
skipped "cranelift/filetests/filetests/isa/x64/basic.clif": missing support for experimental_x64
skipped "cranelift/filetests/filetests/isa/x64/run-const.clif": missing support for experimental_x64
skipped "cranelift/filetests/filetests/isa/x64/simd-lane-access-compile.clif": missing support for experimental_x64
skipped "cranelift/filetests/filetests/isa/x64/simd-lane-access-run.clif": missing support for experimental_x64
4 tests

view this post on Zulip Wasmtime GitHub notifications bot (Sep 29 2020 at 09:54):

github-actions[bot] commented on Issue #2239:

Subscribe to Label Action

cc @bnjbvr

<details>
This issue or pull request has been labeled: "cranelift"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (Sep 29 2020 at 16:17):

abrown commented on Issue #2239:

Something bizarre is happening but I'm not exactly sure what (after a cargo clean):

cargo run --color=always --features experimental_x64 -p cranelift-tools -- test -v ./cranelift/filetests/filetests/isa/x64
    Finished dev [unoptimized + debuginfo] target(s) in 0.10s
     Running `target/debug/clif-util test -v ./cranelift/filetests/filetests/isa/x64`
skipped "./cranelift/filetests/filetests/isa/x64/basic.clif": missing support for experimental_x64
0.000 ./cranelift/filetests/filetests/isa/x64/basic.clif
skipped "./cranelift/filetests/filetests/isa/x64/run-const.clif": missing support for experimental_x64
skipped "./cranelift/filetests/filetests/isa/x64/move-elision.clif": missing support for experimental_x64
skipped "./cranelift/filetests/filetests/isa/x64/simd-lane-access-compile.clif": missing support for experimental_x64
0.000 ./cranelift/filetests/filetests/isa/x64/simd-lane-access-compile.clif
0.000 ./cranelift/filetests/filetests/isa/x64/run-const.clif
skipped "./cranelift/filetests/filetests/isa/x64/simd-lane-access-run.clif": missing support for experimental_x64
0.002 ./cranelift/filetests/filetests/isa/x64/simd-lane-access-run.clif
0.000 ./cranelift/filetests/filetests/isa/x64/move-elision.clif
5 tests

view this post on Zulip Wasmtime GitHub notifications bot (Sep 29 2020 at 16:19):

abrown commented on Issue #2239:

But if I cd cranelift, then:

$ cargo run --color=always --features experimental_x64 -p cranelift-tools -- test -vd ./filetests/filetests/isa/x64
    Finished dev [unoptimized + debuginfo] target(s) in 0.06s
     Running `/home/abrown/Code/wasmtime/target/debug/clif-util test -vd ./filetests/filetests/isa/x64`
0.013 ./filetests/filetests/isa/x64/basic.clif
0.046 ./filetests/filetests/isa/x64/simd-lane-access-compile.clif
0.003 ./filetests/filetests/isa/x64/run-const.clif
0.034 ./filetests/filetests/isa/x64/simd-lane-access-run.clif
0.012 ./filetests/filetests/isa/x64/move-elision.clif
5 tests

view this post on Zulip Wasmtime GitHub notifications bot (Sep 29 2020 at 16:23):

bnjbvr commented on Issue #2239:

Oh oh, i might have run it from the CL directory all the time, and i suspect it's the feature unification issue striking again; if you run from the top-level directory with cargo +nightly -Zfeatures=all -Zpackage-features before the rest of the arguments, does it help?

view this post on Zulip Wasmtime GitHub notifications bot (Sep 29 2020 at 16:23):

bjorn3 commented on Issue #2239:

If you are in the workspace root, then --features applies to wasmtime. Wasmtime has a experimental_x64 feature, but it doesn't enable it for cranelift-tools.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 29 2020 at 16:31):

abrown commented on Issue #2239:

Ha! The extra arguments make it all work; I'll close this issue. And thanks @bjorn3 for the explanation; I had seen those arguments in the ci script but didn't really want to look into why they were needed :big_smile:.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 29 2020 at 16:31):

abrown closed Issue #2239:

#2226 enabled Cranelift filetests but this functionality seems unavailable from the CLI:

$ cargo run --color=always --features experimental_x64 -p cranelift-tools -- test cranelift/filetests/filetests/isa/x64
    Finished dev [unoptimized + debuginfo] target(s) in 0.07s
     Running `target/debug/clif-util test cranelift/filetests/filetests/isa/x64`
skipped "cranelift/filetests/filetests/isa/x64/basic.clif": missing support for experimental_x64
skipped "cranelift/filetests/filetests/isa/x64/run-const.clif": missing support for experimental_x64
skipped "cranelift/filetests/filetests/isa/x64/simd-lane-access-compile.clif": missing support for experimental_x64
skipped "cranelift/filetests/filetests/isa/x64/simd-lane-access-run.clif": missing support for experimental_x64
4 tests

Last updated: Dec 23 2024 at 12:05 UTC