Stream: git-wasmtime

Topic: wasmtime / Issue #2235 Don't implicitly create empty file...

view this post on Zulip Wasmtime GitHub notifications bot (Sep 26 2020 at 01:03):

iximeow commented on Issue #2235:

Good catch, thank you! The changes look good, but (as you've noted) it would be good to have a test around this too. A non-OFLAGS_CREAT counterpart to https://github.com/bytecodealliance/wasmtime/blob/main/crates/test-programs/wasi-tests/src/bin/path_open_create_existing.rs should do the trick. The virtfs testing uses the same test binaries as real-filesystem wasi tests, since they ought to behave the same.

(the actual test generation happens here if you're curious - if a test uses the filesystem, it gets two suites. if not, just one)

view this post on Zulip Wasmtime GitHub notifications bot (Sep 26 2020 at 01:20):

joshuawarner32 commented on Issue #2235:

Hmm, possibly dumb question - how do I run those tests? I've inserted a panic in the test you pointed to, and I don't see a failure with cargo test, in either the root dir, or in the test-programs crate.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 26 2020 at 01:32):

iximeow commented on Issue #2235:

Ah I forgot about that, it's been a minute - I fished around in the CI config and found

        cargo test \
            --features test-programs/test_programs \
            --all \
            --exclude lightbeam \
            --exclude peepmatic \
            --exclude peepmatic-automata \
            --exclude peepmatic-fuzzing \
            --exclude peepmatic-macro \
            --exclude peepmatic-runtime \
            --exclude peepmatic-test

test-programs is a feature you have to enable to get them run in cargo test

view this post on Zulip Wasmtime GitHub notifications bot (Sep 26 2020 at 01:33):

iximeow commented on Issue #2235:

I see you found it :)

view this post on Zulip Wasmtime GitHub notifications bot (Sep 26 2020 at 01:34):

joshuawarner32 commented on Issue #2235:

Haha I found that magic incantation in the wasi-common readme too. Copied it to the test-programs readme to hopefully avoid confusion for others.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 26 2020 at 01:37):

joshuawarner32 commented on Issue #2235:

I'm completely befuddled as to why CI is failing. The line it's pointing to in the error doesn't seem to line up with the code in this PR (the line number is wrong).

view this post on Zulip Wasmtime GitHub notifications bot (Sep 26 2020 at 01:40):

iximeow commented on Issue #2235:

wasmtime tests run against a temporary merge commit against the target branch - you've got a clean merge but semantically this conflicts with https://github.com/bytecodealliance/wasmtime/pull/2201. you can drop the types:: prefix and it should all be good. If you wouldn't mind rebasing on main that'll get you a clean and working test locally too.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 26 2020 at 02:25):

github-actions[bot] commented on Issue #2235:

Subscribe to Label Action

cc @kubkon

<details>
This issue or pull request has been labeled: "wasi"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Last updated: Nov 22 2024 at 16:03 UTC