Wasmtime GitHub notifications bot (Sep 26 2020 at 01:22): Wasmtime GitHub notifications bot (Sep 26 2020 at 01:22):github-actions[bot] commented on Issue #2234:
Subscribe to Label Action
cc @bnjbvr
<details>
This issue or pull request has been labeled: "cranelift", "cranelift:area:x64"Thus the following users have been cc'd because of the following labels:
- bnjbvr: cranelift
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Sep 29 2020 at 06:05):jlb6740 commented on Issue #2234:
Can you add (or port) CLIF run tests, please?
:+1: Will do. I suppose we want keep the file names the same adding only the relevant tests, or do we want to take a different approach such as adding the entire file but somehow disabling tests that are not yet supported?
Wasmtime GitHub notifications bot (Sep 29 2020 at 09:55):bnjbvr commented on Issue #2234:
+1 Will do. I suppose we want keep the file names the same adding only the relevant tests, or do we want to take a different approach such as adding the entire file but somehow disabling tests that are not yet supported?
Whichever is the simplest; adding the whole file and commenting out tests we're not passing sounds fine to me.
Wasmtime GitHub notifications bot (Oct 01 2020 at 09:52):bnjbvr commented on Issue #2234:
From a quick look, lgtm, but I think that @abrown is the most appropriate reviewer here :-)
Wasmtime GitHub notifications bot (Oct 02 2020 at 23:20):jlb6740 commented on Issue #2234:
Think all the comments have been addressed except the potential for some compile testing being added. Can address that in a follow-up patch so will go ahead and merge.
Last updated: Dec 23 2024 at 12:05 UTC