Stream: git-wasmtime

Topic: wasmtime / Issue #2220 Add define_anonymous_data function...

view this post on Zulip Wasmtime GitHub notifications bot (Sep 22 2020 at 18:48):

bjorn3 opened Issue #2220:

Feature

<!-- What is the feature or code improvement you would like to do in
Cranelift/Wasmtime? -->

Add a method to cranelift-module that defines a data object without creating a new symbol.

Benefit

<!-- What is the value of adding this in Cranelift/Wasmtime? -->

Avoiding symbols for anonymous data objects improves linker times.

Implementation

<!-- Do you have an implementation plan, and/or ideas for data structures or
algorithms to use? -->

For cranelift-simplejit symbol names are unused for everything except for imports and exports already. For cranelift-object the data object could be added to the right section and then the section id and offset could be stored to generate the right relocations in the future.

Alternatives

<!-- Have you considered alternative implementations? If so, how are they
better or worse than your proposal? -->
Using Linkage::Local requires you to generate an unique name and has a negative impact on compilation times.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 22 2020 at 20:08):

pchickey commented on Issue #2220:

Seems reasonable to me

view this post on Zulip Wasmtime GitHub notifications bot (Sep 24 2020 at 15:45):

bnjbvr labeled Issue #2220:

Feature

<!-- What is the feature or code improvement you would like to do in
Cranelift/Wasmtime? -->

Add a method to cranelift-module that defines a data object without creating a new symbol.

Benefit

<!-- What is the value of adding this in Cranelift/Wasmtime? -->

Avoiding symbols for anonymous data objects improves linker times.

Implementation

<!-- Do you have an implementation plan, and/or ideas for data structures or
algorithms to use? -->

For cranelift-simplejit symbol names are unused for everything except for imports and exports already. For cranelift-object the data object could be added to the right section and then the section id and offset could be stored to generate the right relocations in the future.

Alternatives

<!-- Have you considered alternative implementations? If so, how are they
better or worse than your proposal? -->
Using Linkage::Local requires you to generate an unique name and has a negative impact on compilation times.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 24 2020 at 15:45):

bnjbvr labeled Issue #2220:

Feature

<!-- What is the feature or code improvement you would like to do in
Cranelift/Wasmtime? -->

Add a method to cranelift-module that defines a data object without creating a new symbol.

Benefit

<!-- What is the value of adding this in Cranelift/Wasmtime? -->

Avoiding symbols for anonymous data objects improves linker times.

Implementation

<!-- Do you have an implementation plan, and/or ideas for data structures or
algorithms to use? -->

For cranelift-simplejit symbol names are unused for everything except for imports and exports already. For cranelift-object the data object could be added to the right section and then the section id and offset could be stored to generate the right relocations in the future.

Alternatives

<!-- Have you considered alternative implementations? If so, how are they
better or worse than your proposal? -->
Using Linkage::Local requires you to generate an unique name and has a negative impact on compilation times.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 24 2020 at 15:46):

github-actions[bot] commented on Issue #2220:

Subscribe to Label Action

cc @bnjbvr

<details>
This issue or pull request has been labeled: "cranelift"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (Apr 12 2021 at 19:11):

cfallin closed Issue #2220:

Feature

<!-- What is the feature or code improvement you would like to do in
Cranelift/Wasmtime? -->

Add a method to cranelift-module that defines a data object without creating a new symbol.

Benefit

<!-- What is the value of adding this in Cranelift/Wasmtime? -->

Avoiding symbols for anonymous data objects improves linker times.

Implementation

<!-- Do you have an implementation plan, and/or ideas for data structures or
algorithms to use? -->

For cranelift-simplejit symbol names are unused for everything except for imports and exports already. For cranelift-object the data object could be added to the right section and then the section id and offset could be stored to generate the right relocations in the future.

Alternatives

<!-- Have you considered alternative implementations? If so, how are they
better or worse than your proposal? -->
Using Linkage::Local requires you to generate an unique name and has a negative impact on compilation times.

Last updated: Dec 23 2024 at 12:05 UTC