github-actions[bot] commented on Issue #2203:
Subscribe to Label Action
cc @bnjbvr
<details>
This issue or pull request has been labeled: "cranelift"Thus the following users have been cc'd because of the following labels:
- bnjbvr: cranelift
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
abrown commented on Issue #2203:
Thanks for doing this! I always thought the previous approach of passing around a bunch of parameters was not the most pleasant.
fitzgen commented on Issue #2203:
I didn't check exact correspondence of the options structs to the old
clap
-based code, but it appears that all the same application logic is there so I assume that means the options values are coming from somewhere (hence nothing is missing).Yep, all the flags and options should be the same, unless I messed something up. I also double checked that the help text is showing up properly for everything.
fitzgen commented on Issue #2203:
And FWIW:
structopt
is generatingclap
code under the covers, so there shouldn't be any big surprises here.
Last updated: Dec 23 2024 at 12:05 UTC