Stream: git-wasmtime

Topic: wasmtime / Issue #2149 This patch fills in the missing pi...

Wasmtime GitHub notifications bot (Aug 20 2020 at 05:54):

github-actions[bot] commented on Issue #2149:

Subscribe to Label Action

cc @bnjbvr

<details>
This issue or pull request has been labeled: "cranelift", "cranelift:area:aarch64", "cranelift:area:x64"

Thus the following users have been cc'd because of the following labels:

• bnjbvr: cranelift

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Aug 20 2020 at 11:22):

julian-seward1 commented on Issue #2149:

As a comment to reviewers: enum AtomicRMWOp in aarch64/inst/args.rs has been cloned exactly into x64/inst/args.rs. I'm not happy about the duplication and would prefer to have only one copy. But where? -- do we have a place where we can put machine-insn artefacts, that are shared across multiple architectures?

Wasmtime GitHub notifications bot (Aug 20 2020 at 11:25):

bjorn3 commented on Issue #2149:

Somewhere in cranelift/codegen/src/machinst probably.

Wasmtime GitHub notifications bot (Aug 21 2020 at 12:00):

julian-seward1 commented on Issue #2149:

All review comments have been addressed.

Wasmtime GitHub notifications bot (Aug 21 2020 at 14:47):

bnjbvr commented on Issue #2149:

One extra comment about the commit message: can you use a shorter one liner for the first line, like machinst x64: implement atomic opcodes, and keep the rest of the commit message in a paragraph below the first line? It's a bit unusual to have a whole paragraph as the commit message, and it doesn't display nicely in misc UIs (github/git).

Last updated: Dec 23 2024 at 13:07 UTC