Stream: git-wasmtime

Topic: wasmtime / Issue #2109 Intermittent CI failure in new x64...

view this post on Zulip Wasmtime GitHub notifications bot (Aug 06 2020 at 18:57):

cfallin opened Issue #2109:

We have temporarily disabled the new x64 backend's CI tests (#2100) because it would intermittently fail these tests with a crash. We need to resolve the underlying issue (perhaps a codegen bug) and re-enable the tests.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 06 2020 at 18:57):

cfallin commented on Issue #2109:

cc @julian-seward1 @bnjbvr

view this post on Zulip Wasmtime GitHub notifications bot (Aug 06 2020 at 18:57):

cfallin labeled Issue #2109:

We have temporarily disabled the new x64 backend's CI tests (#2100) because it would intermittently fail these tests with a crash. We need to resolve the underlying issue (perhaps a codegen bug) and re-enable the tests.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 24 2020 at 13:55):

bnjbvr commented on Issue #2109:

I don't have strong evidence, but I think this has been fixed by https://github.com/bytecodealliance/wasmtime/commit/3849dc18b1bf3560c43950f049fe553034c424b2.

See https://github.com/bytecodealliance/wasmtime/commit/3849dc18b1bf3560c43950f049fe553034c424b2#diff-234d9b09197fd3d4bc69bf1a2ca4f2f8L2410. Before the PR, when emitting a constant null for a reference type, we wouldn't match the is_int, so a floating-point xorps/xorpd would be used to generate the register. According to the result of regalloc, this could result in incorrect code in the best case, uninitialized registers in the worst case. The above patch is a likely fix since the issue was intermittent, and matches this behavior of randomness, and crashes happened around reference type tests (I remember seeing double frees, etc.).

I'll close the issue now; if the intermittent failure happens again, I'm happy to look into it a bit more.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 24 2020 at 13:55):

bnjbvr closed Issue #2109:

We have temporarily disabled the new x64 backend's CI tests (#2100) because it would intermittently fail these tests with a crash. We need to resolve the underlying issue (perhaps a codegen bug) and re-enable the tests.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 24 2020 at 13:55):

bnjbvr labeled Issue #2109:

We have temporarily disabled the new x64 backend's CI tests (#2100) because it would intermittently fail these tests with a crash. We need to resolve the underlying issue (perhaps a codegen bug) and re-enable the tests.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 24 2020 at 13:55):

github-actions[bot] commented on Issue #2109:

Subscribe to Label Action

cc @bnjbvr

<details>
This issue or pull request has been labeled: "cranelift"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Last updated: Dec 23 2024 at 12:05 UTC