Wasmtime GitHub notifications bot (Aug 03 2020 at 23:31): Wasmtime GitHub notifications bot (Aug 03 2020 at 23:31):github-actions[bot] commented on Issue #2088:
Subscribe to Label Action
cc @bnjbvr
<details>
This issue or pull request has been labeled: "cranelift", "cranelift:area:x64"Thus the following users have been cc'd because of the following labels:
- bnjbvr: cranelift
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Aug 04 2020 at 17:22):abrown commented on Issue #2088:
cc: @jlb6740
Wasmtime GitHub notifications bot (Aug 04 2020 at 19:39):jlb6740 commented on Issue #2088:
@abrown Thanks, agree with everything said. As @cfallin said .. the use of types:: prefix is inconsistent so this does improve on that. As you said it does increase verbosity which I think can sometimes reduce readability when it is too redundant, but maybe this allows ide's and the programming to have to parse and deal with less ambiguity. So pros and cons .. I personally wouldn't mind either way. Interested in what others prefer.
Wasmtime GitHub notifications bot (Aug 05 2020 at 17:10):abrown commented on Issue #2088:
I planning on merging this before it gets too out-of-date (especially since #2100 removes the x64 CI check--I ran the x64 tests locally on the rebased version and the unrebased commit already passed the x64 CI check).
Wasmtime GitHub notifications bot (Aug 05 2020 at 17:10):abrown edited a comment on Issue #2088:
I plan on merging this before it gets too out-of-date (especially since #2100 removes the x64 CI check--I ran the x64 tests locally on the rebased version and the unrebased commit already passed the x64 CI check).
Last updated: Dec 23 2024 at 12:05 UTC