Stream: git-wasmtime

Topic: wasmtime / Issue #2070 virtfs file: update cursor positio...


view this post on Zulip Wasmtime GitHub notifications bot (Jul 26 2020 at 13:32):

github-actions[bot] commented on Issue #2070:

Subscribe to Label Action

cc @kubkon

<details>
This issue or pull request has been labeled: "wasi"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (Jul 27 2020 at 11:14):

kubkon commented on Issue #2070:

@ueno the failure on Windows looks...weird. I can help out here with debugging, but won't be able to look at this until evening today.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 27 2020 at 11:54):

ueno commented on Issue #2070:

@ueno the failure on Windows looks...weird. I can help out here with debugging, but won't be able to look at this until evening today.

I suspect that this is because on Windows fd_pwrite returns after writing each iovec, as I see the similar behavior in fd_pread.
Let me try to call fd_pwrite in a loop to ensure that everything is written.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 27 2020 at 12:26):

kubkon commented on Issue #2070:

@ueno the failure on Windows looks...weird. I can help out here with debugging, but won't be able to look at this until evening today.

I suspect that this is because on Windows fd_pwrite returns after writing each iovec, as I see the similar behavior in fd_pread.
Let me try to call fd_pwrite in a loop to ensure that everything is written.

FWIW, if this is the case, we should probably unify the interface in WASI though. I'm happy for us to do this in a subsequent PR so that we don't block virtfs fixes and improvements in this one though.


Last updated: Dec 23 2024 at 12:05 UTC