Wasmtime GitHub notifications bot (Aug 07 2020 at 19:28): Wasmtime GitHub notifications bot (Aug 07 2020 at 19:28):yurydelendik commented on Issue #2064:
I can see the entire ELF image being copied into the code memory, but I'm having trouble figuring out the end goal ofthis PR. Is the intention that the Object isn't kept around which duplicates resident memory by having code twice? This isn't related to minimizing the number of copies, right?
The end goal not only remove copy operations but also reduce amount of data copies as well. Currently, we are keeping pristine ELF image copy along with code_memory, which only needed for
Module::serialize(so almost never). This PR tries to remove this data from memory.It is low priority for this optimization. Though it will probably be needed when we will emit ELF image directly into the code_memory.
Wasmtime GitHub notifications bot (Aug 07 2020 at 20:31):alexcrichton commented on Issue #2064:
Ah ok I see, so it's removing some duplicates we store next to each other. Ok that makes sense to me! I'd be happy landing this since it at least improves along those lines and will be needed for future refactorings anyway.
Last updated: Nov 22 2024 at 17:03 UTC