Stream: git-wasmtime

Topic: wasmtime / Issue #2025 C API: creating a module should re...


view this post on Zulip Wasmtime GitHub notifications bot (Jul 15 2020 at 18:16):

fitzgen opened Issue #2025:

We made changes to the Rust API so that creating a module requires an engine, not a store. However, we didn't propagate this change out to the C API (nor the python API and I assume not to the go or .NET APIs either).

We should do this. It might require using non-standard wasmtime.h functions, unless we convince upstream to make this change as well.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 15 2020 at 18:16):

fitzgen labeled Issue #2025:

We made changes to the Rust API so that creating a module requires an engine, not a store. However, we didn't propagate this change out to the C API (nor the python API and I assume not to the go or .NET APIs either).

We should do this. It might require using non-standard wasmtime.h functions, unless we convince upstream to make this change as well.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 15 2020 at 18:52):

yurydelendik commented on Issue #2025:

We made changes to the Rust API so that creating a module requires an engine, not a store.

Yeah, the reason was HostRef. Now since it is gone we can change signature of wasmtime_module_new.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 15 2020 at 18:54):

yurydelendik edited a comment on Issue #2025:

We made changes to the Rust API so that creating a module requires an engine, not a store.

Yeah, the reason was HostRef. Now since it is gone we can change signature of wasmtime_module_new.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 15 2020 at 20:34):

fitzgen closed Issue #2025:

We made changes to the Rust API so that creating a module requires an engine, not a store. However, we didn't propagate this change out to the C API (nor the python API and I assume not to the go or .NET APIs either).

We should do this. It might require using non-standard wasmtime.h functions, unless we convince upstream to make this change as well.


Last updated: Nov 22 2024 at 17:03 UTC