Stream: git-wasmtime

Topic: wasmtime / Issue #2022 peepmatic: Add bnot operation

Wasmtime GitHub notifications bot (Jul 16 2020 at 11:58):

MaxGraey commented on Issue #2022:

Alright. I removed rule but keep bnot instruction code for peepmatic

Wasmtime GitHub notifications bot (Jul 16 2020 at 19:16):

MaxGraey commented on Issue #2022:

the new backend(s) that are under development, could easily enough match that in their instruction selectors and directly emit a not insn as appropriate. There's no requirement for any more heavyweight

btw one potential goal of early tranformation x ^ -1 to ~x might be canonization for further iterations / post-optimizations. Although I probably didn't go deep into the details of the cranelift architecture and if your pipeline uses only single passes for pre-opt-> post-opt -> target codegen chain this no big deal

Wasmtime GitHub notifications bot (Jul 16 2020 at 19:35):

MaxGraey edited a comment on Issue #2022:

the new backend(s) that are under development, could easily enough match that in their instruction selectors and directly emit a not insn as appropriate. There's no requirement for any more heavyweight

btw one potential goal of early tranformation x ^ -1 to ~x might be canonization for further iterations of peephole optimizations / post-optimizations. Although I probably didn't go deep into the details of the cranelift architecture and if your pipeline uses only single passes for pre-opt-> post-opt -> target codegen chain this no big deal

Last updated: Nov 22 2024 at 16:03 UTC