Wasmtime GitHub notifications bot (Jul 11 2020 at 00:27): Wasmtime GitHub notifications bot (Jul 11 2020 at 00:27):jlb6740 commented on Issue #2011:
Not really sure the definition of fcmp. I believe we need to do a ucomiss and then update some register with the true or false (1 or 0) using the setcc instruction based on the condition code. However I am not sure if this thinking is accurate nor which register should be set?
Wasmtime GitHub notifications bot (Jul 11 2020 at 00:50):github-actions[bot] commented on Issue #2011:
Subscribe to Label Action
cc @bnjbvr
<details>
This issue or pull request has been labeled: "cranelift", "cranelift:area:x64"Thus the following users have been cc'd because of the following labels:
- bnjbvr: cranelift
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Jul 16 2020 at 07:05):jlb6740 commented on Issue #2011:
Note, in addition to the tests in emit tests, I've checked lowering from the wasm level for all the f32 and f64 comparison instructions.
Wasmtime GitHub notifications bot (Jul 16 2020 at 07:07):jlb6740 commented on Issue #2011:
Note the test failure "Run cargo run -p run-examples" runs locally for me.
Wasmtime GitHub notifications bot (Jul 16 2020 at 07:08):jlb6740 edited a comment on Issue #2011:
Note the test failure "Run cargo run -p run-examples" runs locally for me. Maybe a configuration issue?
Wasmtime GitHub notifications bot (Jul 17 2020 at 03:26):jlb6740 commented on Issue #2011:
lgtm, thanks! (can't approve yet, since the other sets of PRs haven't landed yet)
:+1: Will rebase and address the comments in one go once https://github.com/bytecodealliance/wasmtime/pull/2004 has landed.
Last updated: Oct 23 2024 at 20:03 UTC