Stream: git-wasmtime

Topic: wasmtime / Issue #1996 Support reference types in the C API

view this post on Zulip Wasmtime GitHub notifications bot (Jul 08 2020 at 22:14):

github-actions[bot] commented on Issue #1996:

Subscribe to Label Action

cc @peterhuene

<details>
This issue or pull request has been labeled: "wasmtime:c-api"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (Jul 09 2020 at 17:34):

fitzgen commented on Issue #1996:

I think I am going to go only one step towards the "raw" wasm_val_t and wasm_ref_t representation you're describing: removing the double Option bits, but not getting rid of WasmRefInner and its type tagging. This way, wasm_ref_copy and wasm_ref_delete can still be safely implemented, which I think is valuable, even if a bunch of the other wasm_ref_* stuff is not worthwhile.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 09 2020 at 20:59):

alexcrichton commented on Issue #1996:

Hm ok that can work, but trying to think through this, presumably the reason is that wasm_table_* take/return wasm_ref_t, right? For wasm_table_set I think we should not take ownership anyway, so it's less of an issue there, but for wasm_table_get you'd need some way to delete the reference that you acquire. Without tagging we don't know, in isolation, what to delete there.

Given that it seems that to support that API we'd need to have internal tagging. I'll raise an issue on the wasm-c-api repo as well.

Last updated: Nov 22 2024 at 17:03 UTC