Wasmtime GitHub notifications bot (Jul 03 2020 at 08:04): Wasmtime GitHub notifications bot (Jul 03 2020 at 08:04):MaxGraey commented on Issue #1975:
Rewrote to
$(isub 1 $C)but still got test fails in reason:
FAIL filetests/filetests/peepmatic/rem_by_const_power_of_2.clif: panicked in worker #1: not two integers of the same width
Wasmtime GitHub notifications bot (Jul 03 2020 at 08:06):MaxGraey edited a comment on Issue #1975:
Rewrote to
$(isub 1 $C)but still got test fails in reason:
FAIL filetests/filetests/peepmatic/rem_by_const_power_of_2.clif: panicked in worker #1: not two integers of the same width. Thoughts?
Wasmtime GitHub notifications bot (Jul 03 2020 at 08:25):MaxGraey commented on Issue #1975:
It seems macro for folding integers accept only case when both constants have the same bitwidth:
https://github.com/bytecodealliance/wasmtime/blob/main/cranelift/peepmatic/crates/runtime/src/optimizer.rs#L90
Isn't this too restrict?
Wasmtime GitHub notifications bot (Jul 03 2020 at 08:26):github-actions[bot] commented on Issue #1975:
Subscribe to Label Action
cc @fitzgen
<details>
This issue or pull request has been labeled: "cranelift:area:peepmatic"Thus the following users have been cc'd because of the following labels:
- fitzgen: cranelift:area:peepmatic
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Jul 03 2020 at 08:41):MaxGraey edited a comment on Issue #1975:
It seems macro for folding integers accept only case when both constants have the same bitwidth:
https://github.com/bytecodealliance/wasmtime/blob/main/cranelift/peepmatic/crates/runtime/src/optimizer.rs#L90
Isn't this much restriction?
Wasmtime GitHub notifications bot (Jul 03 2020 at 08:42):MaxGraey edited a comment on Issue #1975:
It seems macro for folding integers accept only case when both constants have the same bitwidth:
https://github.com/bytecodealliance/wasmtime/blob/main/cranelift/peepmatic/crates/runtime/src/optimizer.rs#L90
Isn't this too much restriction?
Wasmtime GitHub notifications bot (Jul 06 2020 at 22:12):fitzgen commented on Issue #1975:
It seems macro for folding integers accept only case when both constants have the same bitwidth:
https://github.com/bytecodealliance/wasmtime/blob/main/cranelift/peepmatic/crates/runtime/src/optimizer.rs#L90
Isn't this too much restriction?This restriction is from cranelift's IR's type system. It won't automatically insert sign- or zero-extension (it wouldn't know which to choose) or truncation. Therefore, we don't need to handle such a scenario as input, and we shouldn't generate it as output.
Last updated: Nov 22 2024 at 17:03 UTC