Stream: git-wasmtime

Topic: wasmtime / Issue #1969 wasmtime: Implement `global.{get,s...

Wasmtime GitHub notifications bot (Jul 02 2020 at 18:00):

github-actions[bot] commented on Issue #1969:

Subscribe to Label Action

cc @peterhuene

<details>
This issue or pull request has been labeled: "wasmtime:api"

Thus the following users have been cc'd because of the following labels:

• peterhuene: wasmtime:api

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Jul 02 2020 at 18:20):

fitzgen commented on Issue #1969:

My thinking was that, because no toolchains emit externref globals, it wasn't worth the effort to make the inline JIT fast path generation code more generic. This would also require some cranelift-wasm interface changes.

Do you think it is worth the effort?

Wasmtime GitHub notifications bot (Jul 02 2020 at 18:24):

alexcrichton commented on Issue #1969:

Nah I don't think it's worth it if it requires larger changes. I just thought that it might be simple to implement today if the code was extracted from table.{get,set}, but if that's not the case then this seems fine to me!

Wasmtime GitHub notifications bot (Jul 02 2020 at 19:59):

fitzgen commented on Issue #1969:

@alexcrichton good call on adding tests for the global API with funcref and externref, that actually required a bit of plumbing in the trampoline module. Do you want to take a look at the new commit? Thanks!

Wasmtime GitHub notifications bot (Jul 02 2020 at 21:03):

alexcrichton commented on Issue #1969:

:+1:

Last updated: Dec 23 2024 at 12:05 UTC