Stream: git-wasmtime

Topic: wasmtime / Issue #1965 Use smallvec for avoid allocations...

Wasmtime GitHub notifications bot (Jul 02 2020 at 12:20):

github-actions[bot] commented on Issue #1965:

Subscribe to Label Action

cc @peterhuene

<details>
This issue or pull request has been labeled: "wasmtime:api"

Thus the following users have been cc'd because of the following labels:

• peterhuene: wasmtime:api

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Jul 02 2020 at 14:13):

alexcrichton commented on Issue #1965:

Thanks for this! I'm curious, though, would y'all be able to switch to using the get* family of functions? Not a whole lot of effort has gone into making Func::call (or Func::new) all that fast since it's imagined that most speed-critical usage would use Func::wrap and Func::get*.

Wasmtime GitHub notifications bot (Jul 02 2020 at 15:59):

pepyakin commented on Issue #1965:

That's what we aim for! As a stop gap, however, we are stuck with Func::new since right now the signatures of the all host functions published are not known statically.

Wasmtime GitHub notifications bot (Jul 02 2020 at 16:24):

alexcrichton commented on Issue #1965:

Ok, sounds like a reasonable stopgap in the meantime then

Last updated: Nov 22 2024 at 16:03 UTC