Stream: git-wasmtime

Topic: wasmtime / Issue #1958 Add FD_READ and FD_SEEK to dir han...

Wasmtime GitHub notifications bot (Jul 01 2020 at 19:03):

github-actions[bot] commented on Issue #1958:

Subscribe to Label Action

cc @kubkon

<details>
This issue or pull request has been labeled: "wasi"

Thus the following users have been cc'd because of the following labels:

• kubkon: wasi

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Jul 01 2020 at 20:41):

kubkon commented on Issue #1958:

@sunfishcode I've gone ahead and also permitted FD_SEEK on dir handles so that we can throw EISDIR in fd_pread calls as well. Could you have a look and lemme know what you reckon? In particular, do you think this is reasonable or should we leave FD_SEEK out of the picture, and only remap errnos in fd_read calls leaving fd_pread untouched?

Wasmtime GitHub notifications bot (Jul 01 2020 at 22:04):

kubkon commented on Issue #1958:

Hmm, now that I think about it, should we also give FD_TELL right to dir handles and let fd_seek and fd_tell fail with an appropriate error message (I believe this should be equivalent to EBADF in POSIX)?

Wasmtime GitHub notifications bot (Sep 15 2020 at 08:02):

kubkon commented on Issue #1958:

After many offline discussions with @sunfishcode, we've agreed this is not the best approach so closing for now.

Last updated: Dec 23 2024 at 12:05 UTC