Wasmtime GitHub notifications bot (Jun 30 2020 at 00:02): Wasmtime GitHub notifications bot (Jun 30 2020 at 00:02):github-actions[bot] commented on Issue #1942:
Subscribe to Label Action
cc @bnjbvr, @fitzgen, @peterhuene
<details>
This issue or pull request has been labeled: "cranelift", "cranelift:wasm", "fuzzing", "lightbeam", "wasmtime:api"Thus the following users have been cc'd because of the following labels:
- bnjbvr: cranelift
- fitzgen: fuzzing
- peterhuene: wasmtime:api
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Jun 30 2020 at 14:18):alexcrichton commented on Issue #1942:
Thanks for this!
I think actually
unimplemented!is appropriate in these places. These are all "safe unwraps" in that if the module linking proposal isn't enabled (which for wasmtime it never is) then these items will never come out of the parser and there's nothing to worry about.It might be worth expanding the inline macro to something like
unimplemented!("module linking not implemented yet")so it's more descriptive, but other than that this looks good to me.
Last updated: Nov 22 2024 at 17:03 UTC