Wasmtime GitHub notifications bot (Jun 26 2020 at 16:33): Wasmtime GitHub notifications bot (Jun 26 2020 at 16:33):github-actions[bot] commented on Issue #1928:
Subscribe to Label Action
cc @peterhuene
<details>
This issue or pull request has been labeled: "wasmtime:c-api"Thus the following users have been cc'd because of the following labels:
- peterhuene: wasmtime:c-api
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Jun 26 2020 at 18:36):tschneidereit commented on Issue #1928:
This seems great to me! (Apart from the preposterously large config file, but I saw your comment about that, and oh well :upside_down:)
One question: do you expect people to find this via a link from the overall Wasmtime docs, or do you plan to add a link to it somewhere else?
Wasmtime GitHub notifications bot (Jun 26 2020 at 19:38):alexcrichton commented on Issue #1928:
The intention is that this will be available (once merged) at https://bytecodealliance.github.io/wasmtime/c-api/ (similar to https://bytecodealliance.github.io/wasmtime/api/wasmtime/ for Rust). I'd imagine we'd update our documentation to link to that, such as:
- README.md - where we document language bindings
- crates/c-api/README.md
- https://bytecodealliance.github.io/wasmtime/examples-c-embed.html
- https://bytecodealliance.github.io/wasmtime/lang-c.html ... uh... or maybe fill this out at all?
I'm also hoping that we can use this to help drive forward adding documentation to the upstream API when it's appropriate.
Wasmtime GitHub notifications bot (Jun 26 2020 at 19:42):tschneidereit commented on Issue #1928:
@alexcrichton ok, that all sounds great to me! It probably makes sense to get a review from someone better capable of actually evaluating the technical parts, but as an approach, this looks great to me!
Wasmtime GitHub notifications bot (Jul 01 2020 at 18:39):kubkon commented on Issue #1928:
FWIW, IMHO this is an excellent effort, thanks @alexcrichton!
Wasmtime GitHub notifications bot (Jul 01 2020 at 19:05):alexcrichton commented on Issue #1928:
Thanks for taking a look @kubkon! And yeah I've actually got everything else filled out, which I'll post as a PR next
Last updated: Dec 23 2024 at 12:05 UTC