Stream: git-wasmtime

Topic: wasmtime / Issue #1927 Do not return a no-op function if ...

Wasmtime GitHub notifications bot (Jun 26 2020 at 15:05):

AlexEne commented on Issue #1927:

It seems I have missed some tests, right now the following are failing:

    cli_tests::greeter_preload_command
    cli_tests::minimal_reactor

Wasmtime GitHub notifications bot (Jun 26 2020 at 15:25):

github-actions[bot] commented on Issue #1927:

Subscribe to Label Action

cc @peterhuene

<details>
This issue or pull request has been labeled: "wasmtime:api"

Thus the following users have been cc'd because of the following labels:

• peterhuene: wasmtime:api

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Jun 26 2020 at 16:04):

abrown commented on Issue #1927:

Maybe @alexcrichton?

Wasmtime GitHub notifications bot (Jun 26 2020 at 16:32):

alexcrichton commented on Issue #1927:

I've requested review from @sunfishcode for this

Wasmtime GitHub notifications bot (Jun 29 2020 at 18:34):

AlexEne commented on Issue #1927:

@sunfishcode if you're ok with this change I'll go ahead and fix the tests.

Wasmtime GitHub notifications bot (Aug 07 2020 at 20:17):

sunfishcode commented on Issue #1927:

This change looks good to me. This is a space that we're still figuring out as we go; I think making it an error now makes sense.

Wasmtime GitHub notifications bot (Aug 10 2020 at 09:56):

AlexEne commented on Issue #1927:

Ok, I'll fix the tests and update this PR in the next days

Last updated: Nov 22 2024 at 16:03 UTC