AlexEne commented on Issue #1927:
It seems I have missed some tests, right now the following are failing:
cli_tests::greeter_preload_command cli_tests::minimal_reactor
github-actions[bot] commented on Issue #1927:
Subscribe to Label Action
cc @peterhuene
<details>
This issue or pull request has been labeled: "wasmtime:api"Thus the following users have been cc'd because of the following labels:
- peterhuene: wasmtime:api
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
abrown commented on Issue #1927:
Maybe @alexcrichton?
alexcrichton commented on Issue #1927:
I've requested review from @sunfishcode for this
AlexEne commented on Issue #1927:
@sunfishcode if you're ok with this change I'll go ahead and fix the tests.
sunfishcode commented on Issue #1927:
This change looks good to me. This is a space that we're still figuring out as we go; I think making it an error now makes sense.
AlexEne commented on Issue #1927:
Ok, I'll fix the tests and update this PR in the next days
Last updated: Dec 23 2024 at 13:07 UTC