Stream: git-wasmtime

Topic: wasmtime / Issue #1916 Fix running filetests with custom ...

Wasmtime GitHub notifications bot (Jun 24 2020 at 19:15):

github-actions[bot] commented on Issue #1916:

Subscribe to Label Action

cc @bnjbvr

<details>
This issue or pull request has been labeled: "cranelift", "cranelift:area:machinst", "cranelift:meta"

Thus the following users have been cc'd because of the following labels:

• bnjbvr: cranelift

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Jun 24 2020 at 19:23):

abrown commented on Issue #1916:

@bnjbvr, one other comment: I tried to apply some of the refactorings I saw from your similar commit (e.g. the Box<dyn TargetIsa> to &'a dyn TargetIsa change) but there are likely other things that could be improved. I felt a little bit like I had to work _around_ the Parser instead of _with it_. Perhaps ParseOptions should just have a default_triple: Triple field and both target and default_calling_convention could go away since we could derive those things?

Wasmtime GitHub notifications bot (Jun 29 2020 at 15:54):

abrown commented on Issue #1916:

cc: @cfallin, @julian-seward1, @jlb6740

Wasmtime GitHub notifications bot (Jul 10 2020 at 15:13):

abrown commented on Issue #1916:

Closing in favor of #2003; if we need to match Flags in the future, the code is here.

Last updated: Nov 22 2024 at 16:03 UTC