github-actions[bot] commented on Issue #1916:
Subscribe to Label Action
cc @bnjbvr
<details>
This issue or pull request has been labeled: "cranelift", "cranelift:area:machinst", "cranelift:meta"Thus the following users have been cc'd because of the following labels:
- bnjbvr: cranelift
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
abrown commented on Issue #1916:
@bnjbvr, one other comment: I tried to apply some of the refactorings I saw from your similar commit (e.g. the
Box<dyn TargetIsa>
to&'a dyn TargetIsa
change) but there are likely other things that could be improved. I felt a little bit like I had to work _around_ theParser
instead of _with it_. PerhapsParseOptions
should just have adefault_triple: Triple
field and bothtarget
anddefault_calling_convention
could go away since we could derive those things?
abrown commented on Issue #1916:
cc: @cfallin, @julian-seward1, @jlb6740
abrown commented on Issue #1916:
Closing in favor of #2003; if we need to match
Flags
in the future, the code is here.
Last updated: Dec 23 2024 at 12:05 UTC