Stream: git-wasmtime

Topic: wasmtime / Issue #1913 Command modules are easy to leak m...

Wasmtime GitHub notifications bot (Jun 23 2020 at 19:22):

alexcrichton labeled Issue #1913:

The implementation of "command" modules in Linker will create a new Instance each time an export is invoked. This works well implementation-wise but it's also easy to leak memory and resources unintentionally. No Instance is actually deallocated until the Store is dropped, which means that commands are a vector for repeatedly creating instances by accident without ever actually deleting them.

I'm not really sure what the best way to handle this would be, but we should probably either document this or look into a fix!

cc @sunfishcode

Wasmtime GitHub notifications bot (Jun 23 2020 at 19:22):

alexcrichton opened Issue #1913:

The implementation of "command" modules in Linker will create a new Instance each time an export is invoked. This works well implementation-wise but it's also easy to leak memory and resources unintentionally. No Instance is actually deallocated until the Store is dropped, which means that commands are a vector for repeatedly creating instances by accident without ever actually deleting them.

I'm not really sure what the best way to handle this would be, but we should probably either document this or look into a fix!

cc @sunfishcode

Wasmtime GitHub notifications bot (Jun 23 2020 at 19:22):

github-actions[bot] commented on Issue #1913:

Subscribe to Label Action

cc @peterhuene

<details>
This issue or pull request has been labeled: "wasmtime:api"

Thus the following users have been cc'd because of the following labels:

• peterhuene: wasmtime:api

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Last updated: Dec 23 2024 at 12:05 UTC