Stream: git-wasmtime

Topic: wasmtime / Issue #1910 Factor Wiggle's wasmtime integrati...

Wasmtime GitHub notifications bot (Jun 23 2020 at 02:40):

pchickey commented on Issue #1910:

Still TODO:

• [ ] the special treatment of wasi_proc_exit needs to be specified as a configuration option.
• [ ] much of the internals of the macro that determine e.g. how parameters and results are passed is duplicated from code that exists in wiggle_generate. The wiggle_generate implementations were designed to be reusable for over in Lucet, so we should be able to cut that code down to a fraction of the size.
• [ ] better name for generate_struct_for_wiggle

Wasmtime GitHub notifications bot (Jun 23 2020 at 02:55):

github-actions[bot] commented on Issue #1910:

Subscribe to Label Action

cc @kubkon

<details>
This issue or pull request has been labeled: "wasi"

Thus the following users have been cc'd because of the following labels:

• kubkon: wasi

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Jun 23 2020 at 23:29):

pchickey edited a comment on Issue #1910:

Still TODO:

• [x] the special treatment of wasi_proc_exit needs to be specified as a configuration option.
• [ ] much of the internals of the macro that determine e.g. how parameters and results are passed is duplicated from code that exists in wiggle_generate. The wiggle_generate implementations were designed to be reusable for over in Lucet, so we should be able to cut that code down to a fraction of the size.
• [ ] better name for generate_struct_for_wiggle

Wasmtime GitHub notifications bot (Jun 23 2020 at 23:29):

pchickey edited a comment on Issue #1910:

Still TODO:

• [x] the special treatment of wasi_proc_exit needs to be specified as a configuration option.
• [ ] much of the internals of the macro that determine e.g. how parameters and results are passed is duplicated from code that exists in wiggle_generate. The wiggle_generate implementations were designed to be reusable for over in Lucet, so we should be able to cut that code down to a fraction of the size.
• [x] better name for generate_struct_for_wiggle

Wasmtime GitHub notifications bot (Jun 24 2020 at 21:00):

pchickey edited a comment on Issue #1910:

Still TODO:

• [x] the special treatment of wasi_proc_exit needs to be specified as a configuration option.
• [x] much of the internals of the macro that determine e.g. how parameters and results are passed is duplicated from code that exists in wiggle_generate. The wiggle_generate implementations were designed to be reusable for over in Lucet, so we should be able to cut that code down to a fraction of the size.
• [x] better name for generate_struct_for_wiggle

Wasmtime GitHub notifications bot (Jun 24 2020 at 22:27):

pchickey commented on Issue #1910:

TODO:

• [ ] this new crate should have a test of the macro that actually executes some wasmtime code
• [ ] the macro should emit a #[test] that verifies that the witx document provided here, and provided at the target, are equal

Wasmtime GitHub notifications bot (Jun 25 2020 at 16:34):

pchickey commented on Issue #1910:

I'm going to take care of those remaining TODOs in a follow-up PR, the testing story presently is that wasi-common works correctly according to CI, so this is correct enough for its previous use case.

Last updated: Nov 22 2024 at 16:03 UTC