Stream: git-wasmtime

Topic: wasmtime / Issue #1903 wasmtime: add config option for pa...

Wasmtime GitHub notifications bot (Jun 24 2020 at 18:01):

ueno commented on Issue #1903:

Thank you for the suggestions; I've added a separate config option in Tunables.

Wasmtime GitHub notifications bot (Jun 24 2020 at 18:27):

github-actions[bot] commented on Issue #1903:

Subscribe to Label Action

cc @peterhuene

<details>
This issue or pull request has been labeled: "wasmtime:api"

Thus the following users have been cc'd because of the following labels:

• peterhuene: wasmtime:api

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Jun 24 2020 at 21:30):

alexcrichton commented on Issue #1903:

This is looks pretty good to me, thanks!

Before merging though I wanted to confirm something. Does this work being a runtime configuration option? Is the purpose here to control memory usage? It seems like systems likely either support threads or they don't, and for systems that don't support threads it may make more sense for this to be a build-time configuration option. If the purpose is something like controlling memory usage though then that makes sense because it's specific to the runtime in question.

Wasmtime GitHub notifications bot (Jun 25 2020 at 12:58):

ueno commented on Issue #1903:

The primary motivation of this is to run wasmtime on an environment which doesn't (yet) support threads, so disabling it at build-time would indeed make sense. I'll try to turn the option into a build-time configuration.

Wasmtime GitHub notifications bot (Jun 25 2020 at 15:58):

alexcrichton commented on Issue #1903:

Ok makes sense! To be clear though I'm not saying this must change, I mostly just wanted to confirm if it worked for you. While a runtime configuration is possible I'm not sure if the target in question doesn't have std::thread at all or if it just returns errors. It's probably easiest to make this a runtime configuration option anyway.

Wasmtime GitHub notifications bot (Jun 29 2020 at 17:28):

npmccallum commented on Issue #1903:

@alexcrichton @ueno I agree this probably makes the most sense as a compile-time feature flag.

Wasmtime GitHub notifications bot (Jul 02 2020 at 13:48):

ueno commented on Issue #1903:

Sorry for the delay; I've updated the PR to use feature flag.

Wasmtime GitHub notifications bot (Jul 06 2020 at 14:25):

github-actions[bot] commented on Issue #1903:

Subscribe to Label Action

cc @kubkon

<details>
This issue or pull request has been labeled: "wasi"

Thus the following users have been cc'd because of the following labels:

• kubkon: wasi

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Last updated: Nov 22 2024 at 17:03 UTC