Stream: git-wasmtime

Topic: wasmtime / Issue #1869 cranelift: add a new resumable_tra...

Wasmtime GitHub notifications bot (Jun 12 2020 at 11:24):

github-actions[bot] commented on Issue #1869:

Subscribe to Label Action

cc @bnjbvr

<details>
This issue or pull request has been labeled: "cranelift", "cranelift:area:aarch64", "cranelift:meta"

Thus the following users have been cc'd because of the following labels:

• bnjbvr: cranelift

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Jun 12 2020 at 12:38):

bnjbvr commented on Issue #1869:

Just for context: the reason why I added a new instruction, rather than creating manually the blocks and use the resumable_trap instruction is that when lowering wasm to clif, we can't mutate the CFG in place (we can't create new blocks). Allow mutation of the CFG at this place would be nice in the future, and could allow new things (of the same kind that the IR template proposal would allow), but this is out of scope for what appears to be really a bug fix here.

Wasmtime GitHub notifications bot (Jun 12 2020 at 12:44):

bnjbvr commented on Issue #1869:

Fuzz-target failure is caused by https://github.com/XAMPPRocky/remove_dir_all/issues/19.

Wasmtime GitHub notifications bot (Jun 12 2020 at 12:44):

bnjbvr edited a comment on Issue #1869:

Fuzz-target failure is being discussed in https://github.com/XAMPPRocky/remove_dir_all/issues/19.

Wasmtime GitHub notifications bot (Jun 12 2020 at 17:00):

fitzgen commented on Issue #1869:

https://github.com/bytecodealliance/wasmtime/blob/master/cranelift/codegen/src/regalloc/safepoint.rs#L54 should probably switch to something like

if pos.func.dfg[inst].is_resumable_trap() { ... }

that returns true for both resumable_trap and resumable_trapnz.

Wasmtime GitHub notifications bot (Jun 12 2020 at 17:23):

bnjbvr commented on Issue #1869:

@fitzgen Thanks! Added something to that effect. (It didn't seem worth to make it a flag visible from the meta crate, but let me know if you think it's better (maybe for consistency? probably the other way around would be better imo))

Wasmtime GitHub notifications bot (Jun 12 2020 at 17:28):

fitzgen commented on Issue #1869:

(It didn't seem worth to make it a flag visible from the meta crate, but let me know if you think it's better (maybe for consistency? probably the other way around would be better imo))

Not 100% sure what you're getting at here, but the changes in this PR look great to me!

Last updated: Oct 23 2024 at 20:03 UTC