Wasmtime GitHub notifications bot (Jun 11 2020 at 21:39): Wasmtime GitHub notifications bot (Jun 11 2020 at 21:39):github-actions[bot] commented on Issue #1866:
Subscribe to Label Action
cc @bnjbvr
<details>
This issue or pull request has been labeled: "cranelift"Thus the following users have been cc'd because of the following labels:
- bnjbvr: cranelift
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Jun 11 2020 at 21:55):cfallin commented on Issue #1866:
AFAICT, it's currently 1.41: link.
Just pushed a CI config tweak to build with that -- let's see if this does the right thing...
Wasmtime GitHub notifications bot (Jun 11 2020 at 21:58):alexcrichton commented on Issue #1866:
FWIW defaulting all our CI to a minimum Rust may be pretty onerous to support over time (I'd be pretty surprised if it passed here actually). I think it's ok though to only build the expected pieces to integrate with Firefox with that compiler version (e.g. cranelift, not wasmtime or peepmatic).
Wasmtime GitHub notifications bot (Jun 11 2020 at 21:59):cfallin commented on Issue #1866:
Yup, just realized this is probably a bad idea. Just working out the YAML magic needed to build cranelift-{codegen,wasm} alone in Rust 1.41, will push momentarily...
Wasmtime GitHub notifications bot (Jun 12 2020 at 09:09):bnjbvr commented on Issue #1866:
For what it's worth, Firefox is meant to support 1.43 as well. The build failure that Chris saw is in a specific build configuration. I've poked a few people on the Mozilla's side to see if we could get this investigated and fixed.
Last updated: Dec 23 2024 at 13:07 UTC