Stream: git-wasmtime

Topic: wasmtime / Issue #1849 Cranelift: stack maps assume refer...

view this post on Zulip Wasmtime GitHub notifications bot (Jun 09 2020 at 21:29):

fitzgen opened Issue #1849:

If cranelift_wasm::TargetEnvironment::reference_type is overridden to use r32 on a 64-bit arch, or overridden to use r64 on a 32-bit arch, then stack maps will be incorrect. This prevents NaN boxing on 32-bit, for example.

The reference size should probably be piped through to TargetIsa or something, and then that used as the unit of granularity for stack maps, instead of pointer size.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 09 2020 at 21:29):

fitzgen labeled Issue #1849:

If cranelift_wasm::TargetEnvironment::reference_type is overridden to use r32 on a 64-bit arch, or overridden to use r64 on a 32-bit arch, then stack maps will be incorrect. This prevents NaN boxing on 32-bit, for example.

The reference size should probably be piped through to TargetIsa or something, and then that used as the unit of granularity for stack maps, instead of pointer size.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 09 2020 at 21:29):

fitzgen labeled Issue #1849:

If cranelift_wasm::TargetEnvironment::reference_type is overridden to use r32 on a 64-bit arch, or overridden to use r64 on a 32-bit arch, then stack maps will be incorrect. This prevents NaN boxing on 32-bit, for example.

The reference size should probably be piped through to TargetIsa or something, and then that used as the unit of granularity for stack maps, instead of pointer size.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 09 2020 at 21:29):

fitzgen labeled Issue #1849:

If cranelift_wasm::TargetEnvironment::reference_type is overridden to use r32 on a 64-bit arch, or overridden to use r64 on a 32-bit arch, then stack maps will be incorrect. This prevents NaN boxing on 32-bit, for example.

The reference size should probably be piped through to TargetIsa or something, and then that used as the unit of granularity for stack maps, instead of pointer size.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 09 2020 at 21:29):

github-actions[bot] commented on Issue #1849:

Subscribe to Label Action

cc @bnjbvr

<details>
This issue or pull request has been labeled: "cranelift"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Last updated: Dec 23 2024 at 12:05 UTC